From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ECBDE210F52BD for ; Sun, 19 Aug 2018 21:57:22 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2018 21:57:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,263,1531810800"; d="scan'208";a="84720271" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2018 21:57:22 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Aug 2018 21:57:22 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 19 Aug 2018 21:57:21 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Mon, 20 Aug 2018 12:57:20 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: Remove redundant functions Thread-Index: AQHUNDnqnmV5I8ZOaU+q5ohhHcJk96TIHAZw Date: Mon, 20 Aug 2018 04:57:20 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBAF4D1@shsmsx102.ccr.corp.intel.com> References: <20180815014609.19948-1-shenglei.zhang@intel.com> <20180815014609.19948-8-shenglei.zhang@intel.com> In-Reply-To: <20180815014609.19948-8-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2018 04:57:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 15, 2018 9:46 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: Remove redundant func= tions The functions that are never called have been removed. They are SdCardGetCsd and SdCardGetScr. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 107 ------------------ 1 file changed, 107 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c b/MdeModulePkg/B= us/Pci/SdMmcPciHcDxe/SdDevice.c index 9e70de956f..8c93933bc6 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c @@ -318,116 +318,9 @@ SdCardSetRca ( return Status; } =20 -/** - Send command SEND_CSD to the SD device to get the data of the CSD regist= er. - - Refer to SD Physical Layer Simplified Spec 4.1 Section 4.7 for details. - - @param[in] PassThru A pointer to the EFI_SD_MMC_PASS_THRU_PROTOCOL= instance. - @param[in] Slot The slot number of the SD card to send the com= mand to. - @param[in] Rca The relative device address of selected device= . - @param[out] Csd The buffer to store the content of the CSD reg= ister. - Note the caller should ignore the lowest byte = of this - buffer as the content of this byte is meaningl= ess even - if the operation succeeds. - - @retval EFI_SUCCESS The operation is done correctly. - @retval Others The operation fails. - -**/ -EFI_STATUS -SdCardGetCsd ( - IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, - IN UINT8 Slot, - IN UINT16 Rca, - OUT SD_CSD *Csd - ) -{ - EFI_SD_MMC_COMMAND_BLOCK SdMmcCmdBlk; - EFI_SD_MMC_STATUS_BLOCK SdMmcStatusBlk; - EFI_SD_MMC_PASS_THRU_COMMAND_PACKET Packet; - EFI_STATUS Status; - - ZeroMem (&SdMmcCmdBlk, sizeof (SdMmcCmdBlk)); - ZeroMem (&SdMmcStatusBlk, sizeof (SdMmcStatusBlk)); - ZeroMem (&Packet, sizeof (Packet)); - - Packet.SdMmcCmdBlk =3D &SdMmcCmdBlk; - Packet.SdMmcStatusBlk =3D &SdMmcStatusBlk; - Packet.Timeout =3D SD_MMC_HC_GENERIC_TIMEOUT; =20 - SdMmcCmdBlk.CommandIndex =3D SD_SEND_CSD; - SdMmcCmdBlk.CommandType =3D SdMmcCommandTypeAc; - SdMmcCmdBlk.ResponseType =3D SdMmcResponseTypeR2; - SdMmcCmdBlk.CommandArgument =3D (UINT32)Rca << 16; =20 - Status =3D SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - if (!EFI_ERROR (Status)) { - // - // For details, refer to SD Host Controller Simplified Spec 3.0 Table = 2-12. - // - CopyMem (((UINT8*)Csd) + 1, &SdMmcStatusBlk.Resp0, sizeof (SD_CSD) - 1= ); - } - - return Status; -} - -/** - Send command SEND_CSD to the SD device to get the data of the CSD regist= er. - - Refer to SD Physical Layer Simplified Spec 4.1 Section 4.7 for details. =20 - @param[in] PassThru A pointer to the EFI_SD_MMC_PASS_THRU_PROTOCOL= instance. - @param[in] Slot The slot number of the SD card to send the com= mand to. - @param[in] Rca The relative device address of selected device= . - @param[out] Scr The buffer to store the content of the SCR reg= ister. - - @retval EFI_SUCCESS The operation is done correctly. - @retval Others The operation fails. - -**/ -EFI_STATUS -SdCardGetScr ( - IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, - IN UINT8 Slot, - IN UINT16 Rca, - OUT SD_SCR *Scr - ) -{ - EFI_SD_MMC_COMMAND_BLOCK SdMmcCmdBlk; - EFI_SD_MMC_STATUS_BLOCK SdMmcStatusBlk; - EFI_SD_MMC_PASS_THRU_COMMAND_PACKET Packet; - EFI_STATUS Status; - - ZeroMem (&SdMmcCmdBlk, sizeof (SdMmcCmdBlk)); - ZeroMem (&SdMmcStatusBlk, sizeof (SdMmcStatusBlk)); - ZeroMem (&Packet, sizeof (Packet)); - - Packet.SdMmcCmdBlk =3D &SdMmcCmdBlk; - Packet.SdMmcStatusBlk =3D &SdMmcStatusBlk; - Packet.Timeout =3D SD_MMC_HC_GENERIC_TIMEOUT; - - SdMmcCmdBlk.CommandIndex =3D SD_APP_CMD; - SdMmcCmdBlk.CommandType =3D SdMmcCommandTypeAc; - SdMmcCmdBlk.ResponseType =3D SdMmcResponseTypeR1; - SdMmcCmdBlk.CommandArgument =3D (UINT32)Rca << 16; - - Status =3D SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - if (EFI_ERROR (Status)) { - return Status; - } - - SdMmcCmdBlk.CommandIndex =3D SD_SEND_SCR; - SdMmcCmdBlk.CommandType =3D SdMmcCommandTypeAdtc; - SdMmcCmdBlk.ResponseType =3D SdMmcResponseTypeR1; - - Packet.InDataBuffer =3D Scr; - Packet.InTransferLength =3D sizeof (SD_SCR); - - Status =3D SdMmcPassThruPassThru (PassThru, Slot, &Packet, NULL); - - return Status; -} =20 /** Send command SELECT_DESELECT_CARD to the SD device to select/deselect it= . --=20 2.18.0.windows.1