From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0DC0A210FB9CF for ; Tue, 21 Aug 2018 19:14:29 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2018 19:14:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,272,1531810800"; d="scan'208";a="74671979" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 21 Aug 2018 19:12:49 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 21 Aug 2018 19:12:48 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 21 Aug 2018 19:12:48 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Wed, 22 Aug 2018 10:12:46 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [PATCH] MdeModulePkg UhciPei: Remove a redundant function Thread-Index: AQHUObpwPsSYpFeD6UG9wjwsM6zOT6TLB4cg Date: Wed, 22 Aug 2018 02:12:45 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBB07F6@shsmsx102.ccr.corp.intel.com> References: <20180822014940.13192-1-shenglei.zhang@intel.com> In-Reply-To: <20180822014940.13192-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg UhciPei: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 02:14:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It is changing EhciPei but not UhciPei, please update the title. Reviewed-by: Star Zeng with the title updated. Thanks, Star -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, August 22, 2018 9:50 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH] MdeModulePkg UhciPei: Remove a redundant function The function UsbHcUnlinkMemBlock that is never called and its related comme= nts have been removed. It is missed in the patch series according to the log in https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/EhciPei/UsbHcMem.c | 27 ------------------------- 1 file changed, 27 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/EhciPei/UsbHcMem.c b/MdeModulePkg/Bus/Pci= /EhciPei/UsbHcMem.c index 3cc31f5054..9f048e7b27 100644 --- a/MdeModulePkg/Bus/Pci/EhciPei/UsbHcMem.c +++ b/MdeModulePkg/Bus/Pci/EhciPei/UsbHcMem.c @@ -293,31 +293,6 @@ UsbHcIsMemBlockEmpty ( return TRUE; } =20 -/** - Unlink the memory block from the pool's list. - - @param Head The block list head of the memory's pool. - @param BlockToUnlink The memory block to unlink. - -**/ -VOID -UsbHcUnlinkMemBlock ( - IN USBHC_MEM_BLOCK *Head, - IN USBHC_MEM_BLOCK *BlockToUnlink - ) -{ - USBHC_MEM_BLOCK *Block; - - ASSERT ((Head !=3D NULL) && (BlockToUnlink !=3D NULL)); - - for (Block =3D Head; Block !=3D NULL; Block =3D Block->Next) { - if (Block->Next =3D=3D BlockToUnlink) { - Block->Next =3D BlockToUnlink->Next; - BlockToUnlink->Next =3D NULL; - break; - } - } -} =20 /** Initialize the memory management pool for the host controller. @@ -390,8 +365,6 @@ UsbHcFreeMemPool ( =20 // // Unlink all the memory blocks from the pool, then free them. - // UsbHcUnlinkMemBlock can't be used to unlink and free the - // first block. // for (Block =3D Pool->Head->Next; Block !=3D NULL; Block =3D Block->Next)= { UsbHcFreeMemBlock (Ehc, Pool, Block); -- 2.18.0.windows.1