From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B60C21A09130 for ; Mon, 27 Aug 2018 21:54:00 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2018 21:53:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,298,1531810800"; d="scan'208";a="85498434" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 27 Aug 2018 21:53:55 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Aug 2018 21:53:55 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Aug 2018 21:53:54 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Tue, 28 Aug 2018 12:53:52 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , Laszlo Ersek , "Zeng, Star" Thread-Topic: [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs Thread-Index: AQHUPoFUFNA7U7SgAkyjt6GMc5LhKaTUmOdQ Date: Tue, 28 Aug 2018 04:53:52 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBB29E0@shsmsx102.ccr.corp.intel.com> References: <20180828034257.19060-1-shenglei.zhang@intel.com> <20180828034257.19060-12-shenglei.zhang@intel.com> In-Reply-To: <20180828034257.19060-12-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2018 04:54:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="windows-1256" Content-Transfer-Encoding: quoted-printable Shenglei, The library Pcdlib is not linked=EF=BC=8C so "#include " is deleted. There is massy code, please correct it before it can be pushed. Thanks, Star -----Original Message----- From: Zhang, Shenglei=20 Sent: Tuesday, August 28, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Las= zlo Ersek Subject: [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs The PCDs below are unused, so they have been removed from inf. gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem The library Pcdlib is not linked=EF=BC=8C so "#include " is deleted. Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Star Zeng --- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 1 - .../Library/= DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 11 ----------- 2 files changed, 12 deletions(-) diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeMod= ulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c index 91c6849a46..fe3ee93523 100644 --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c @@ -39,7 +39,6 @@ #include #include #include -#include #include =20 #include diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf= b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf index 342df9e99c..d5e87cb97b 100644 --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf @@ -56,17 +56,6 @@ HobLib BmpSupportLib =20 -[Pcd] - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax = ## CONSUMES - gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag = ## CONSUMES - - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule = ## CONSUMES - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin = ## CONSUMES - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd = ## CONSUMES - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware = ## CONSUMES - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess= ## CONSUMES - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed = ## CONSUMES - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem = ## CONSUMES =20 [Protocols] gEsrtManagementProtocolGuid ## CONSUMES -- 2.18.0.windows.1