Re: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs

["Zeng, Star" <star.zeng@intel.com>]

Sure. :)
I just sent a separated patch for it at https://lists.01.org/pipermail/edk2-devel/2018-September/029832.html.


Thanks,
Star
-----Original Message-----
From: Gao, Liming 
Sent: Tuesday, September 18, 2018 10:19 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Younas khan <pmdyounaskhan786@gmail.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: RE: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs

Star:
  The change in MdePkg is good. Because you add two APIs in UefiLib library class, could you also update FrameworkUefiLib in IntelFrameworkPkg?

Thanks
Liming
> -----Original Message-----
> From: Zeng, Star
> Sent: Monday, September 17, 2018 5:08 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Younas khan 
> <pmdyounaskhan786@gmail.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Yao, 
> Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; 
> Ni, Ruiyu <ruiyu.ni@intel.com>; Bi, Dandan <dandan.bi@intel.com>; 
> Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs
> 
> It is the V3 patch series of
> https://lists.01.org/pipermail/edk2-devel/2018-August/029214.html
> It is according to the discussion at
> https://lists.01.org/pipermail/edk2-devel/2018-September/029750.html
> 
> V3:
> 1. Pick Ray/Laszlo/Eric's RB.
> 2. Remove ASSERT about Signature check.
> 3. Merge ScanTableInRSDT and ScanTableInXSDT.
> 
> It is the V2 patch series of
> https://lists.01.org/pipermail/edk2-devel/2018-August/029214.html
> It is according to the discussion at
> https://lists.01.org/pipermail/edk2-devel/2018-September/029348.html
> 
> V2:
> 1. Add EfiLocateFirstAcpiTable() and EfiLocateNextAcpiTable() instead
>    of EfiFindAcpiTableBySignature() to support locating both single
>    ACPI table instance and multiple ACPI table instances cases.
> 2. Support locating DSDT.
> 3. Support locating multiple ACPI table instances case by
>    EfiLocateNextAcpiTable().
> 
> Test done:
> 1. Call EfiLocateFirstAcpiTable() before ACPI configuration table is
>    installed, NULL is returned.
> 2. Call EfiLocateFirstAcpiTable() to locate FACS after FACS is installed
>    but FADT is not installed, NULL is returned.
> 3. Call EfiLocateFirstAcpiTable() to locate FADT/DSDT/FACS/FPDT/DMAR
>    at late phase, correct ACPI table pointer is returned.
> 4. Call EfiLocateNextAcpiTable() to locate SSDTs at late phase, all
>    SSDTs are returned correctly.
> 5. Run same test cases above after setting PcdAcpiExposedTableVersions
>    to 0x2, same results are with above.
> 6. Run same test cases above with 32Bits build, same results are with
>    above.
> 
> The code for this patch series is also at 
> git@github.com:lzeng14/edk2.git branch LocateAcpiTable_UefiLibV3
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=967
> Request to add a library function for GetAcpiTable() in order to get 
> ACPI table using signature as input.
> 
> After evaluation, we found there are many duplicated code to find ACPI 
> table by signature in different modules.
> 
> This patch adds new EfiLocateXXXAcpiTable() API in UefiLib for the 
> request and removing the duplicated code.
> 
> Cc: Younas khan <pmdyounaskhan786@gmail.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> 
> Star Zeng (6):
>   MdePkg UefiLib: Add new EfiLocateXXXAcpiTable() APIs
>   IntelSiliconPkg IntelVTdDxe: Use new EfiLocateFirstAcpiTable()
>   MdeModulePkg S3SaveStateDxe: Use new EfiLocateFirstAcpiTable()
>   PcAtChipsetPkg PcRtc: Use new EfiLocateFirstAcpiTable()
>   ShellPkg DpDynamicCommand: Use new EfiLocateFirstAcpiTable()
>   UefiCpuPkg PiSmmCpuDxeSmm: Use new EfiLocateFirstAcpiTable()
> 
>  .../Feature/VTd/IntelVTdDxe/DmarAcpiTable.c        | 136 +------
>  .../Acpi/S3SaveStateDxe/AcpiS3ContextSave.c        | 208 +---------
>  .../Acpi/S3SaveStateDxe/S3SaveStateDxe.inf         |   3 +-
>  MdePkg/Include/Library/UefiLib.h                   |  68 ++++
>  MdePkg/Library/UefiLib/Acpi.c                      | 428 +++++++++++++++++++++
>  MdePkg/Library/UefiLib/UefiLib.inf                 |   3 +
>  PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c |  80 +---
>  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c      | 136 +------
>  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h      |   1 -
>  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni    |   1 -
>  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf |   2 -
>  .../DpDynamicCommand/DpDynamicCommand.inf          |   2 -
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf       |   4 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c             |  84 +---
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h     |   3 +-
>  15 files changed, 519 insertions(+), 640 deletions(-)  create mode 
> 100644 MdePkg/Library/UefiLib/Acpi.c
> 
> --
> 2.7.0.windows.1