From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E88A21142FEE for ; Tue, 18 Sep 2018 18:29:01 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 18:29:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,392,1531810800"; d="scan'208";a="87319446" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 18 Sep 2018 18:29:01 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 18:29:00 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 18:29:00 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.16]) with mapi id 14.03.0319.002; Wed, 19 Sep 2018 09:28:57 +0800 From: "Zeng, Star" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: Younas khan , "Kinney, Michael D" , "Yao, Jiewen" , "Wang, Jian J" , "Ni, Ruiyu" , "Bi, Dandan" , "Dong, Eric" , "Laszlo Ersek" , "Zeng, Star" Thread-Topic: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs Thread-Index: AQHUTmX9JwFSmsqLr0uESNUi+jvgaaT1khyAgAFBOxA= Date: Wed, 19 Sep 2018 01:28:56 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BBBB466@shsmsx102.ccr.corp.intel.com> References: <1537175295-37508-1-git-send-email-star.zeng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2F8EE7@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2F8EE7@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 01:29:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure. :) I just sent a separated patch for it at https://lists.01.org/pipermail/edk2= -devel/2018-September/029832.html. Thanks, Star -----Original Message----- From: Gao, Liming=20 Sent: Tuesday, September 18, 2018 10:19 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Younas khan ; Kinney, Michael D ; Yao, Jiewen ; Wang, Jian J ; Ni, Ruiyu ; Bi, Dandan ; Dong, Eric ; Laszlo Ersek Subject: RE: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs Star: The change in MdePkg is good. Because you add two APIs in UefiLib library= class, could you also update FrameworkUefiLib in IntelFrameworkPkg? Thanks Liming > -----Original Message----- > From: Zeng, Star > Sent: Monday, September 17, 2018 5:08 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Younas khan=20 > ; Kinney, Michael D=20 > ; Gao, Liming ; Yao,=20 > Jiewen ; Wang, Jian J ;=20 > Ni, Ruiyu ; Bi, Dandan ;=20 > Dong, Eric ; Laszlo Ersek > Subject: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs >=20 > It is the V3 patch series of > https://lists.01.org/pipermail/edk2-devel/2018-August/029214.html > It is according to the discussion at > https://lists.01.org/pipermail/edk2-devel/2018-September/029750.html >=20 > V3: > 1. Pick Ray/Laszlo/Eric's RB. > 2. Remove ASSERT about Signature check. > 3. Merge ScanTableInRSDT and ScanTableInXSDT. >=20 > It is the V2 patch series of > https://lists.01.org/pipermail/edk2-devel/2018-August/029214.html > It is according to the discussion at > https://lists.01.org/pipermail/edk2-devel/2018-September/029348.html >=20 > V2: > 1. Add EfiLocateFirstAcpiTable() and EfiLocateNextAcpiTable() instead > of EfiFindAcpiTableBySignature() to support locating both single > ACPI table instance and multiple ACPI table instances cases. > 2. Support locating DSDT. > 3. Support locating multiple ACPI table instances case by > EfiLocateNextAcpiTable(). >=20 > Test done: > 1. Call EfiLocateFirstAcpiTable() before ACPI configuration table is > installed, NULL is returned. > 2. Call EfiLocateFirstAcpiTable() to locate FACS after FACS is installed > but FADT is not installed, NULL is returned. > 3. Call EfiLocateFirstAcpiTable() to locate FADT/DSDT/FACS/FPDT/DMAR > at late phase, correct ACPI table pointer is returned. > 4. Call EfiLocateNextAcpiTable() to locate SSDTs at late phase, all > SSDTs are returned correctly. > 5. Run same test cases above after setting PcdAcpiExposedTableVersions > to 0x2, same results are with above. > 6. Run same test cases above with 32Bits build, same results are with > above. >=20 > The code for this patch series is also at=20 > git@github.com:lzeng14/edk2.git branch LocateAcpiTable_UefiLibV3 >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D967 > Request to add a library function for GetAcpiTable() in order to get=20 > ACPI table using signature as input. >=20 > After evaluation, we found there are many duplicated code to find ACPI=20 > table by signature in different modules. >=20 > This patch adds new EfiLocateXXXAcpiTable() API in UefiLib for the=20 > request and removing the duplicated code. >=20 > Cc: Younas khan > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Ruiyu Ni > Cc: Dandan Bi > Cc: Eric Dong > Cc: Laszlo Ersek >=20 > Star Zeng (6): > MdePkg UefiLib: Add new EfiLocateXXXAcpiTable() APIs > IntelSiliconPkg IntelVTdDxe: Use new EfiLocateFirstAcpiTable() > MdeModulePkg S3SaveStateDxe: Use new EfiLocateFirstAcpiTable() > PcAtChipsetPkg PcRtc: Use new EfiLocateFirstAcpiTable() > ShellPkg DpDynamicCommand: Use new EfiLocateFirstAcpiTable() > UefiCpuPkg PiSmmCpuDxeSmm: Use new EfiLocateFirstAcpiTable() >=20 > .../Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 136 +------ > .../Acpi/S3SaveStateDxe/AcpiS3ContextSave.c | 208 +--------- > .../Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 3 +- > MdePkg/Include/Library/UefiLib.h | 68 ++++ > MdePkg/Library/UefiLib/Acpi.c | 428 +++++++++++++++= ++++++ > MdePkg/Library/UefiLib/UefiLib.inf | 3 + > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 80 +--- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 136 +------ > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 1 - > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 1 - > ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 2 - > .../DpDynamicCommand/DpDynamicCommand.inf | 2 - > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 4 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 84 +--- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 3 +- > 15 files changed, 519 insertions(+), 640 deletions(-) create mode=20 > 100644 MdePkg/Library/UefiLib/Acpi.c >=20 > -- > 2.7.0.windows.1