public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation
Date: Tue, 9 Oct 2018 08:24:06 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BC1372A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu--NjZOhcwkMoagenqWWDcdKFwkO7mSx3S08EGwewSV7Q@mail.gmail.com>

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
Sent: Tuesday, October 9, 2018 3:13 PM
To: Gao, Liming <liming.gao@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation

On 9 October 2018 at 09:11, Gao, Liming <liming.gao@intel.com> wrote:
> This issue in LzmaEnc.c is for encode. The copy SDK in MdeModulePkg and IntelFrameworkModulepkg is for decode. So, other copy SDK has no this issue.
>

I understand.

Thanks for the fix

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
>> Sent: Tuesday, October 9, 2018 3:08 PM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel@lists.01.org
>> Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation
>>
>> On 9 October 2018 at 09:06, Liming Gao <liming.gao@intel.com> wrote:
>> > GCC 6 or above reports the warning misleading-indentation.
>> > This patch fixes it.
>> >
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Liming Gao <liming.gao@intel.com>
>> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> > ---
>> >  BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++-
>> >  1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c
>> > index bebe664..e281716 100644
>> > --- a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c
>> > +++ b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c
>> > @@ -1464,7 +1464,9 @@ static unsigned GetOptimum(CLzmaEnc *p, UInt32 position)
>> >          unsigned limit = p->numFastBytes + 1;
>> >          if (limit > numAvailFull)
>> >            limit = numAvailFull;
>> > -        for (len = 3; len < limit && data[len] == data2[len]; len++);
>> > +        for (len = 3; len < limit && data[len] == data2[len]; len++)
>> > +        {
>> > +        }
>> >
>> >          {
>> >            unsigned state2 = kLiteralNextStates[state];
>>
>> Thanks Liming.
>>
>> Don't we need this change in all copies of the LZMA SDK?
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-10-09  8:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09  7:06 [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation Liming Gao
2018-10-09  7:07 ` Ard Biesheuvel
2018-10-09  7:11   ` Gao, Liming
2018-10-09  7:12     ` Ard Biesheuvel
2018-10-09  8:24       ` Zeng, Star [this message]
2018-10-09 10:13         ` Laszlo Ersek
2018-10-09 10:24           ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BC1372A@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox