From: "Zeng, Star" <star.zeng@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2 00/12] Need to validate data from HW
Date: Wed, 17 Oct 2018 02:43:38 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BC1F55C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20181016054335.47460-1-ruiyu.ni@intel.com>
Series Reviewed-by: Star Zeng <star.zeng@intel.com>
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Tuesday, October 16, 2018 1:43 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 00/12] Need to validate data from HW
The patches contain logic to check the data from HW before using.
It can avoid corrupted data from HW causes software behave abnormally.
V2: adopt all comments from Star. The block size 0/64K handle is in a separate patch
"MdeModulePkg/UsbMass: Reject device whose block size is 0 or > 64K"
Hao Wu (1):
MdeModulePkg/Bus/Ufs: Ensure device not return more data than expected
Ruiyu Ni (11):
MdeModulePkg/UsbMass: Merge UsbBoot(Read|Write)Blocks(16)
MdeModulePkg/UsbMass: Fix integer overflow when BlockSize is 1
MdeModulePkg/UsbBus: Fix out-of-bound read access to descriptors
MdeModulePkg/UsbBus: Reject descriptor whose length is bad
MdeModulePkg/Usb: Make sure data from HW is no more than expected
SourceLevelDebugPkg/Usb3: Make sure data from HW can fit in buffer
MdeModulePkg/UsbKb: Don't access key codes when length is wrong
MdeModulePkg/AbsPointer: Don't access key codes when length is wrong
MdeModulePkg/UsbMouse: Don't access key codes when length is wrong
MdeModulePkg/UsbBus: Deny when the string descriptor length is odd
MdeModulePkg/UsbMass: Reject device whose block size is 0 or > 64K
MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 9 +-
MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c | 7 +-
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 +-
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 19 +-
.../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 30 ++-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 70 +++++-
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 4 +
.../Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 276 ++++++---------------
.../Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 76 ++----
.../Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 8 +-
.../UsbMouseAbsolutePointer.c | 8 +-
MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 8 +-
.../DebugCommunicationLibUsb3Transfer.c | 7 +
13 files changed, 237 insertions(+), 294 deletions(-)
--
2.16.1.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-10-17 2:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 5:43 [PATCH v2 00/12] Need to validate data from HW Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 01/12] MdeModulePkg/UsbMass: Merge UsbBoot(Read|Write)Blocks(16) Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 02/12] MdeModulePkg/UsbMass: Fix integer overflow when BlockSize is 1 Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 03/12] MdeModulePkg/UsbBus: Fix out-of-bound read access to descriptors Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 04/12] MdeModulePkg/UsbBus: Reject descriptor whose length is bad Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 05/12] MdeModulePkg/Usb: Make sure data from HW is no more than expected Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 06/12] SourceLevelDebugPkg/Usb3: Make sure data from HW can fit in buffer Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 07/12] MdeModulePkg/UsbKb: Don't access key codes when length is wrong Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 08/12] MdeModulePkg/AbsPointer: " Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 09/12] MdeModulePkg/UsbMouse: " Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 10/12] MdeModulePkg/UsbBus: Deny when the string descriptor length is odd Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 11/12] MdeModulePkg/Bus/Ufs: Ensure device not return more data than expected Ruiyu Ni
2018-10-16 5:43 ` [PATCH v2 12/12] MdeModulePkg/UsbMass: Reject device whose block size is 0 or > 64K Ruiyu Ni
2018-10-17 2:43 ` Zeng, Star [this message]
2018-10-17 2:46 ` [PATCH v2 00/12] Need to validate data from HW Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103BC1F55C@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox