From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B5CB211799F7 for ; Tue, 16 Oct 2018 19:48:55 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 19:48:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,389,1534834800"; d="scan'208";a="266319079" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 16 Oct 2018 19:48:55 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 19:48:55 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 19:48:54 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.217]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 10:48:52 +0800 From: "Zeng, Star" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: Paulo Alcantara , Paulo Alcantara , "Ni, Ruiyu" , "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [PATCH v2 0/6] Code refinements in UdfDxe Thread-Index: AQHUZShPt74SntZN7UKSNgyRp/OSkaUivW/w Date: Wed, 17 Oct 2018 02:48:51 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BC1F59B@shsmsx102.ccr.corp.intel.com> References: <20181016081442.24236-1-hao.a.wu@intel.com> In-Reply-To: <20181016081442.24236-1-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/6] Code refinements in UdfDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 02:48:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Wu, Hao A=20 Sent: Tuesday, October 16, 2018 4:15 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Paulo Alcantara ; P= aulo Alcantara ; Ni, Ruiyu ; Zeng, Star= ; Yao, Jiewen Subject: [PATCH v2 0/6] Code refinements in UdfDxe Note: Since PATCH v2 1/6 ~ 5/6 have not been changed, add the 'Reviewed-by:' tag = during the v1 series review. V2 changes: A. Drop PATCH v1 6/7, since removing those codes will make the function MangleFileName() not matching its original implementation purpose (according to the function description). B. Drop change C in PATCH v1 7/7. It is reasonable for function SetFileInfo() to handle the expected value for the input parameters. C. Refine the log message for PATCH v1 7/7. V1 history: This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe for: A. Refine asserts used for memory allocation failure and error cases that are possible to happen. Will use error handling logic for them; B. Address some dead codes within this module. Cc: Paulo Alcantara Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Star Zeng Cc: Jiewen Yao Hao Wu (6): MdeModulePkg/UdfDxe: Use error handling for memory allocation failure MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref MdeModulePkg/UdfDxe: Use error handling when fail to return LSN MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen() MdeModulePkg/UdfDxe: Handle dead codes in File.c MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c MdeModulePkg/Universal/Disk/UdfDxe/File.c | 19 ++- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 158 ++++++++++= +++++----- 2 files changed, 138 insertions(+), 39 deletions(-) -- 2.12.0.windows.1