From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24C692116821C for ; Sun, 28 Oct 2018 06:35:31 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2018 06:35:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,436,1534834800"; d="scan'208";a="103185312" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 28 Oct 2018 06:35:31 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 28 Oct 2018 06:35:30 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 28 Oct 2018 06:35:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0415.000; Sun, 28 Oct 2018 21:35:28 +0800 From: "Zeng, Star" To: "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Wu, Hao A" , "Wang, Jian J" , "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer Thread-Index: AQHUbTGbYC1xG9KfVE+JA3wtRJbH7KU0q6Zg Date: Sun, 28 Oct 2018 13:35:27 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103BC5C57C@shsmsx102.ccr.corp.intel.com> References: <1540561286-112684-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1540561286-112684-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjA1NmM2ZDktNDYyNS00OWYzLTgyNjUtZmUxOGY0NDNiYTUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTCtoWUtwaU5aMFZpU0duVGhvRzAzOElRdHdPM2gxRGgrUjlOM0JQRUxpQmFwUVhXcjZidGhHandxaVFDV3B0NCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 13:35:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for all the reviews, I just pushed the patches at https://github.com= /tianocore/edk2/compare/a6eb94e...0cd6452. Star -----Original Message----- From: Zeng, Star=20 Sent: Friday, October 26, 2018 9:41 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Ni, Ruiyu ; Wu, H= ao A ; Wang, Jian J ; Yao, Jiewe= n Subject: [PATCH V3 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for= AsyncInterruptTransfer V3: Thanks for Hao's feedback. 1. Match function parameter name and description between XhciSched.c and Xh= ciSched.h, EhciSched.c and EhciSched.h. 2. Call XhcFreeUrb after XhcCreateTransferTrb fails in XhcCreateTrb. V2: Thanks for Ray's feedback. 1. Add the missing "FreePool (Data);". 2. Remove the unnecessary indentation change. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1274 Please refer to the log message of each commit for more details. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J Wang Cc: Jiewen Yao Star Zeng (4): MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function MdeModulePkg EhciDxe: Extract new EhciInsertAsyncIntTransfer function MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 28 +---- MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 114 +++++++++---------- MdeMod= ulePkg/Bus/Pci/EhciDxe/EhciSched.h | 35 +++++- MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 38 ++++++- MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h | 33 +++--- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 19 +--- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 185 +++++++++++++++++----------= ---- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 55 +++++++-- 8 files changed, 296 insertions(+), 211 deletions(-) -- 2.7.0.windows.1