From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E813421962301 for ; Sun, 18 Nov 2018 21:49:25 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2018 21:48:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,251,1539673200"; d="scan'208";a="105734691" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 18 Nov 2018 21:48:02 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 18 Nov 2018 21:48:02 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 18 Nov 2018 21:48:02 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0415.000; Mon, 19 Nov 2018 13:48:00 +0800 From: "Zeng, Star" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Zeng, Star" Thread-Topic: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr Thread-Index: AQHUf8HebeHyiYj0p0OXI2F5AttvV6VWl0Ag Date: Mon, 19 Nov 2018 05:47:59 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB048310401F2BC2@shsmsx102.ccr.corp.intel.com> References: <20181119043848.15328-1-shenglei.zhang@intel.com> In-Reply-To: <20181119043848.15328-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjMyMTAxMDMtYmI0Yi00NTBiLTkwY2UtNmFkNTAxNjkxYTY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVWc3WWxzYkFtSk82citsc3J1SDRwYkd1TngyNVNJN3UydGRtcmswUlc4UkswZFwvcjBPWTJpSFJBdTFUck5rSXEifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 05:49:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Shen= glei Zhang Sent: Monday, November 19, 2018 12:39 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star Subject: [edk2] [PATCH v2] MdeModulePkg: Remove PcdIdentifyMappingPageTable= Ptr PcdIdentifyMappingPageTablePtr was used to share page table buffer between = modules. Buf after some changes on 2015/07/17, it was useless and could be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1304 v2: 1.Remove PcdIdentifyMappingPageTablePtr in MdeModulePkg.uni. 2.Update the commit message. Cc: Star Zeng Cc: Jian J Wang Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/MdeModulePkg.dec | 6 ------ MdeModulePkg/MdeModulePkg.uni | = 4 ---- 2 files changed, 10 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec = index 428eeeb670..0abacc1a90 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -2007,12 +2007,6 @@ # @ValidList 0x80000001 | 0x0 gEfiMdeModulePkgTokenSpaceGuid.PcdS3BootScriptTablePrivateSmmDataPtr|0x0= |UINT64|0x00030001 =20 - ## This dynamic PCD hold an address to point to the memory of page table= . The page table establishes a 1:1 - # Virtual to Physical mapping according to the processor physical addre= ss bits. - # @Prompt Identify Mapping Page Table pointer. - # @ValidList 0x80000001 | 0x0 - gEfiMdeModulePkgTokenSpaceGuid.PcdIdentifyMappingPageTablePtr|0x0|UINT64= |0x00030002 - ## This dynamic PCD holds the information if there is any test key used = by the platform. # @Prompt If there is any test key used by the platform. gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE|BOOLEAN|0x00030003 diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni = index 5fa7a6ae30..038e848505 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -914,10 +914,6 @@ = "this PCD to be TURE if and only if all runtime driver has = seperated Code/Data\n" = "section. If PE code/data sections are merged, the result i= s unpredictable.\n" =20 -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdIdentifyMappingPageTablePtr_= PROMPT #language en-US "Identify Mapping Page Table pointer." - -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdIdentifyMappingPageTablePtr_= HELP #language en-US "This dynamic PCD hold an address to point to the mem= ory of page table. The page table establishes a 1:1\n" - = "Virtual to Physical mapping according to the process= or physical address bits." #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdShadowPeimOnBoot_HELP #lang= uage en-US "Indicates if to shadow PEIM and PeiCore after memory is ready.<= BR>
\n" = "This PCD is used on other boot path except for S3 boot.\n" = "TRUE - Shadow PEIM and PeiCore after memory is ready.
\n" -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel