From: "Zeng, Star" <star.zeng@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2 0/2] Fix constant if statement issue
Date: Thu, 22 Nov 2018 05:04:20 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB048310401F4245@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20181122035103.16940-1-chasel.chiu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Chasel, Chiu
Sent: Thursday, November 22, 2018 11:51 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: [edk2] [PATCH v2 0/2] Fix constant if statement issue
Internal code quality scanning found 2 constant if statements related to FixedPcdGet8 () usage.
Since the PCD can be PatchableInModule too, it should be changed to PcdGet8 () to fix this issue.
Also fixed the line ending format issue from previous patch.
Patch1 fixed line ending format issue on some files
Patch2 fixed constant if statement issue.
Cc: Jiewen Yao <Jiewen.yao@intel.com>
Cc: Desimone Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: Wu Hao A <hao.a.wu@intel.com>
Chasel, Chiu (2):
IntelFsp2WrapperPkg: Fix line ending format issue
IntelFsp2WrapperPkg: Fix constant if statements issue
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 32 ++++++++++++++++----------------
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 24 ++++++++++++------------
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 4 ++-- IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 4 ++--
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 22 +++++++++++-----------
5 files changed, 43 insertions(+), 43 deletions(-)
--
2.13.3.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-11-22 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 3:51 [PATCH v2 0/2] Fix constant if statement issue Chasel, Chiu
2018-11-22 3:51 ` [PATCH v2 1/2] IntelFsp2WrapperPkg: Fix line ending format issue Chasel, Chiu
2018-11-22 5:00 ` Wu, Hao A
2018-11-22 3:51 ` [PATCH v2 2/2] IntelFsp2WrapperPkg: Fix constant if statements issue Chasel, Chiu
2018-11-22 5:01 ` Wu, Hao A
2018-11-22 5:04 ` Zeng, Star [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB048310401F4245@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox