From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B879421962301 for ; Thu, 22 Nov 2018 01:02:21 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Nov 2018 01:02:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,265,1539673200"; d="scan'208";a="108390766" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 22 Nov 2018 01:02:21 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 21 Nov 2018 21:05:49 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.161]) with mapi id 14.03.0415.000; Thu, 22 Nov 2018 13:04:20 +0800 From: "Zeng, Star" To: "Chiu, Chasel" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [edk2] [PATCH v2 0/2] Fix constant if statement issue Thread-Index: AQHUghaosMMM0A5tU0eQ2YqJgwUjI6VbPWFA Date: Thu, 22 Nov 2018 05:04:20 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB048310401F4245@shsmsx102.ccr.corp.intel.com> References: <20181122035103.16940-1-chasel.chiu@intel.com> In-Reply-To: <20181122035103.16940-1-chasel.chiu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmJmMTcyNTQtOTc4Ny00MGFmLTk2NmMtYWVmNWY4YzkyMDQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUEhlVlZyNGZwVFM3VGRZRU0xUUVMajBlMVFCbWUzT2lTV0tLck5mWTl2R1FDeDFNMzUzM3lJNVZISGI3UTlmcCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/2] Fix constant if statement issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 09:02:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Chas= el, Chiu Sent: Thursday, November 22, 2018 11:51 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Yao, Jiewen Subject: [edk2] [PATCH v2 0/2] Fix constant if statement issue Internal code quality scanning found 2 constant if statements related to Fi= xedPcdGet8 () usage. Since the PCD can be PatchableInModule too, it should be changed to PcdGet8= () to fix this issue. Also fixed the line ending format issue from previous patch. Patch1 fixed line ending format issue on some files Patch2 fixed constant if statement issue. Cc: Jiewen Yao Cc: Desimone Nathaniel L Cc: Wu Hao A Chasel, Chiu (2): IntelFsp2WrapperPkg: Fix line ending format issue IntelFsp2WrapperPkg: Fix constant if statements issue IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 32 +++++++++++++= +++---------------- IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 24 ++++++++++++-= ----------- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 4 ++-- IntelFs= p2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 4 ++-- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 22 +++++++++++--= --------- 5 files changed, 43 insertions(+), 43 deletions(-) -- 2.13.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel