From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D5DAC21962301 for ; Tue, 8 Jan 2019 17:18:16 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2019 17:18:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,455,1539673200"; d="scan'208";a="132854904" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 08 Jan 2019 17:18:16 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 8 Jan 2019 17:18:16 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 8 Jan 2019 17:18:15 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 09:18:13 +0800 From: "Zeng, Star" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Zeng, Star" Thread-Topic: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib Thread-Index: AQHUp51FSVI2h9KsrEK9F6aLCkcGWaWmIqaw Date: Wed, 9 Jan 2019 01:18:13 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB048310402434C5@shsmsx102.ccr.corp.intel.com> References: <59678190473f66f8a44d5be7ff416275c365342c.1546984652.git.jaben.carsey@intel.com> In-Reply-To: <59678190473f66f8a44d5be7ff416275c365342c.1546984652.git.jaben.carsey@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 01:18:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable How about updating "2018" to "2019"? :) With that, Reviewed-by: Star Zeng . Thanks, Star -----Original Message----- From: Carsey, Jaben=20 Sent: Wednesday, January 9, 2019 5:58 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib The comments are incorrect for the base version of this lib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey Cc: Star Zeng Cc: Jian J Wang --- MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------ 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c b/MdeModulePkg/= Library/BaseSortLib/BaseSortLib.c index ab8a60585ee2..8f30c00971eb 100644 --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c @@ -1,7 +1,7 @@ /** @file Library used for sorting routines. =20 - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.=20 +
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -193,14 +193,12 @@ DevicePathCompare ( } =20 /** - Function to compare 2 strings without regard to case of the characters. + Not supported in Base version. =20 - @param[in] Buffer1 Pointer to String to compare. - @param[in] Buffer2 Pointer to second String to compare. + @param[in] Buffer1 Ignored. + @param[in] Buffer2 Ignored. =20 - @retval 0 Buffer1 equal to Buffer2. - @return < 0 Buffer1 is less than Buffer2. - @return > 0 Buffer1 is greater than Buffer2. + ASSERT and return 0. **/ INTN EFIAPI @@ -215,14 +213,12 @@ StringNoCaseCompare ( =20 =20 /** - Function to compare 2 strings. + Not supported in Base version. =20 - @param[in] Buffer1 Pointer to String to compare (CHAR16**). - @param[in] Buffer2 Pointer to second String to compare (CHAR1= 6**). + @param[in] Buffer1 Ignored. + @param[in] Buffer2 Ignored. =20 - @retval 0 Buffer1 equal to Buffer2. - @return < 0 Buffer1 is less than Buffer2. - @return > 0 Buffer1 is greater than Buffer2. + ASSERT and return 0. **/ INTN EFIAPI -- 2.16.2.windows.1