Re: [Patch 0/2] Use correct field name.

["Zeng, Star" <star.zeng@intel.com>]

Agree with Laszlo's comments to those two patches.

Reviewed-by: Star Zeng <star.zeng@intel.com>

Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Friday, January 11, 2019 6:45 PM
To: Dong, Eric <eric.dong@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ray <ray.ni@intel.com>; Aleksiy <oleksiyy@ami.com>
Subject: Re: [edk2] [Patch 0/2] Use correct field name.

On 01/11/19 06:46, Eric Dong wrote:
> ((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) != 0))
> 
> In above code, Facs->OspmFlags should be used instead.
> EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware 
> Control Structure Flags field, not in Firmware Control Structure 
> Feature Flags.
> 
> Update all related code to use correct field name.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1430
> 
> Cc: Aleksiy <oleksiyy@ami.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Eric Dong (2):
>   UefiCpuPkg/S3Resume2Pei: Use correct field name.
>   MdeModulePkg/BootScriptExecuteorDxe: Use correct field name.
> 
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c   | 4 ++--
>  MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 ++--
>  UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c                   | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 

Regression-tested-by: Laszlo Ersek <lersek@redhat.com> _______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel