From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5BE6421959CB2 for ; Sun, 13 Jan 2019 19:18:24 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2019 19:18:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,476,1539673200"; d="scan'208";a="311544852" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 13 Jan 2019 19:18:24 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 13 Jan 2019 19:18:24 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 13 Jan 2019 19:18:23 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 11:18:22 +0800 From: "Zeng, Star" To: Laszlo Ersek , "Dong, Eric" , "edk2-devel@lists.01.org" CC: "Ni, Ray" , Aleksiy , "Zeng, Star" Thread-Topic: [edk2] [Patch 0/2] Use correct field name. Thread-Index: AQHUqXEZjyOoF+9kiUyNZO9FgENs06WpXG8AgATABtA= Date: Mon, 14 Jan 2019 03:18:21 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB04831040247CD9@shsmsx102.ccr.corp.intel.com> References: <20190111054639.25528-1-eric.dong@intel.com> <91711939-5a5e-11d3-691b-830cb8062584@redhat.com> In-Reply-To: <91711939-5a5e-11d3-691b-830cb8062584@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/2] Use correct field name. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 03:18:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree with Laszlo's comments to those two patches. Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Friday, January 11, 2019 6:45 PM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Ni, Ray ; Aleksiy Subject: Re: [edk2] [Patch 0/2] Use correct field name. On 01/11/19 06:46, Eric Dong wrote: > ((Facs->Flags & EFI_ACPI_4_0_OSPM_64BIT_WAKE__F) !=3D 0)) >=20 > In above code, Facs->OspmFlags should be used instead. > EFI_ACPI_4_0_OSPM_64BIT_WAKE__F is a bit in OSPM Enabled Firmware=20 > Control Structure Flags field, not in Firmware Control Structure=20 > Feature Flags. >=20 > Update all related code to use correct field name. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1430 >=20 > Cc: Aleksiy > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Jian Wang > Eric Dong (2): > UefiCpuPkg/S3Resume2Pei: Use correct field name. > MdeModulePkg/BootScriptExecuteorDxe: Use correct field name. >=20 > MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/ScriptExecute.c | 4 = ++-- > MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 = ++-- > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 6 = +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 Regression-tested-by: Laszlo Ersek ____________________= ___________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel