From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ACC31211ADA22 for ; Fri, 18 Jan 2019 02:45:42 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2019 02:45:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,491,1539673200"; d="scan'208";a="119494033" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 18 Jan 2019 02:45:41 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 18 Jan 2019 02:45:41 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 18 Jan 2019 02:45:41 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.150]) with mapi id 14.03.0415.000; Fri, 18 Jan 2019 18:45:39 +0800 From: "Zeng, Star" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" , "Ye, Ting" , "Wei, Gang" , "Wang, Jian J" , "Zhang, Chao B" , "Yao, Jiewen" , "Wu, Hao A" , Achin Gupta , Jagadeesh Ujja , "Zeng, Star" Thread-Topic: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules Thread-Index: AQHUreGaIiOP6MKhrEa5YO8SCyiR7qW0r7UggAAp1WA= Date: Fri, 18 Jan 2019 10:45:38 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483104024E4ED@shsmsx102.ccr.corp.intel.com> References: <20190116212221.7460-1-ard.biesheuvel@linaro.org> <20190116212221.7460-4-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483104024E338@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483104024E338@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2Y0NTM2NDItZjJiMC00ZmJhLTg1YjMtZTg1NTI2Mzc5ZGUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidFB0ZmRGd1JhZkxlb2xPaWhLOXFmYnZjNHV6Uzh1Q0xpbWpsUHBWS0VpRWtBVGZZMGNrcGZPUGJCZVlQakg1VSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 10:45:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Anther, the parameters of constructor are removed, so their descriptions in= function header also need to be cleaned up. Same comment to patch 2. With = them fixed, Reviewed-by: Star Zeng to the series. Thanks, Star -----Original Message----- From: Zeng, Star=20 Sent: Friday, January 18, 2019 4:15 PM To: Ard Biesheuvel ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming ; Ye, Ting ; Wei, Gang ; = Wang, Jian J ; Zhang, Chao B ; Yao, Jiewen ; Wu, Hao A ; Achi= n Gupta ; Jagadeesh Ujja ; Zen= g, Star Subject: RE: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDAL= ONE modules This patch does not touch VarCheckLib at all, but only touch VarCheckUefiLi= b, so the title and commit message need be updated. With them updated correctly, Reviewed-by: Star Zeng . Thanks, Star -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]=20 Sent: Thursday, January 17, 2019 5:22 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming ; Ye, Ting ; Wei, Gang ; Wang, Jian J ; Zhang, Chao B ; Yao, Jiewen ; Wu, Hao A ; Zeng, Star ; A= chin Gupta ; Jagadeesh Ujja Subject: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE = modules Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++-- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 +++++-= --- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf b/Mde= ModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf index 128c44d695e1..8873fd51a02a 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf @@ -19,9 +19,9 @@ [Defines] BASE_NAME =3D VarCheckUefiLib MODULE_UNI_FILE =3D VarCheckUefiLib.uni FILE_GUID =3D AC24A4C7-F845-4665-90E5-6431D6E28DC0 - MODULE_TYPE =3D DXE_RUNTIME_DRIVER + MODULE_TYPE =3D BASE VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVE= R + LIBRARY_CLASS =3D NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRIVE= R MM_STANDALONE CONSTRUCTOR =3D VarCheckUefiLibNullClassConstructor =20 # diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.= c b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c index 80dc6341adcf..5e419831e8cc 100644 --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. =20 **/ =20 +#include + #include #include #include @@ -927,15 +929,14 @@ VariablePropertySetUefiDefined ( @retval EFI_SUCCESS The constructor executed correctly. =20 **/ -EFI_STATUS +RETURN_STATUS EFIAPI VarCheckUefiLibNullClassConstructor ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE *SystemTable + VOID ) { VariablePropertySetUefiDefined (); VarCheckLibRegisterSetVariableCheckHandler (SetVariableCheckHandlerUefiD= efined); =20 - return EFI_SUCCESS; + return RETURN_SUCCESS; } -- 2.17.1