Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

["Zeng, Star" <star.zeng@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 5, 2019 4:03 PM
> To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>;
> ard.biesheuvel@linaro.org; Leif Lindholm <leif.lindholm@linaro.org>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Andrew Fish <afish@apple.com>
> Cc: devel@edk2.groups.io
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> On 06/05/19 03:10, Ni, Ray wrote:
> > Hi everyone,
> >
> > Hao pushed the patch because:
> > 1. it's a bug fix
> > 2. it got a R-b.
> > I don't think it's his fault.
> >
> > For #1, it's gap in process.
> > For #2, it's my fault. Because even the patch title says EmulatorPkg but the
> patch itself changes MdeModulePkg, I am still the person who can approve
> changes in both packages.
> >
> > In Maintainers.txt:
> > R: Ray Ni <ray.ni@intel.com>
> >   (especially for Bus, Universal/Console, Universal/Disk,
> >    Universal/BdsDxe and related libraries, header files)
> >
> > The UiApp actually is not in the "especially" part, but the word "especially"
> > means I can also R-b to other components. In fact, I am not quite
> > qualified on the other components, e.g.: UiApp.
> > So I propose to assign clear reviewers for each components in
> MdeModulePkg.
> > What do you think?
> 
> Fully agreed. MdeModulePkg is huge and we should have fine-grained
> maintainership assignments.

I also agree.

> 
> Thanks
> Laszlo
> 
>