From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: star.zeng@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Sun, 16 Jun 2019 18:51:15 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2019 18:51:15 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 16 Jun 2019 18:51:15 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 18:51:15 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 18:51:15 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000; Mon, 17 Jun 2019 09:51:14 +0800 From: "Zeng, Star" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. Thread-Index: AQHVIpdy8iNIt5abiEibmbnRG3zGZqaeRAiggADUzeA= Date: Mon, 17 Jun 2019 01:51:14 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483104032F9B9@shsmsx102.ccr.corp.intel.com> References: <20190614095621.5824-1-chasel.chiu@intel.com> <15A8AFDD4EE2EEDF.4443@groups.io> In-Reply-To: <15A8AFDD4EE2EEDF.4443@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGZlMzNmOGYtM2FhNC00MTg0LWIzMzktMzc2MTlmYTJlZjhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicDZWUFFCTHRVZmhLdzFsNDR2WFpDbElDeXorc2FGcTNMK1FwWUszdjdzVGZ4b09IUkxPSFhnamNvYXU1cXJVQyJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: star.zeng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable And the 'Ppi' postfix seems not needed in the file name. Thanks, Star > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zeng, Star > Sent: Sunday, June 16, 2019 9:11 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. >=20 > Hi Chasel, >=20 > Two minor feedbacks. >=20 > 1. The spec defines the return status below, should we follow it? >=20 > EFI_SUCCESS FSP execution environment was initialized successfully. > EFI_INVALID_PARAMETER Input parameters are invalid. > EFI_UNSUPPORTED The FSP calling conditions were not met. > EFI_DEVICE_ERROR Temporary memory exit. >=20 >=20 > 2. The gFspTempRamExitPpiGuid should be added into IntelFsp2Pkg.dec, > right? >=20 >=20 > Thanks, > Star >=20 > > -----Original Message----- > > From: Chiu, Chasel > > Sent: Friday, June 14, 2019 5:56 PM > > To: devel@edk2.groups.io > > Cc: Desimone, Nathaniel L ; Zeng, Star > > > > Subject: [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1883 > > > > Add header file for FSP_TEMP_RAM_EXIT_PPI which is defined by FSP 2.1 > > spec. > > > > Test: Build successfully. > > > > Cc: Nate DeSimone > > Cc: Star Zeng > > Signed-off-by: Chasel Chiu > > --- > > IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h | 50 > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > > b/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > > new file mode 100644 > > index 0000000000..9e728a5d4d > > --- /dev/null > > +++ b/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > > @@ -0,0 +1,50 @@ > > +/** @file > > + This file defines the Silicon Temp Ram Exit PPI which implements > > +the > > + required programming steps for disabling temporary memory. > > + > > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> > +SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#ifndef _FSP_TEMP_RAM_EXIT_PPI_H_ > > +#define _FSP_TEMP_RAM_EXIT_PPI_H_ > > + > > +/// > > +/// Global ID for the FSP_TEMP_RAM_EXIT_PPI. > > +/// > > +#define FSP_TEMP_RAM_EXIT_GUID \ > > + { \ > > + 0xbc1cfbdb, 0x7e50, 0x42be, { 0xb4, 0x87, 0x22, 0xe0, 0xa9, 0x0c, > > +0xb0, > > 0x52 } \ > > + } > > + > > +// > > +// Forward declaration for the FSP_TEMP_RAM_EXIT_PPI. > > +// > > +typedef struct _FSP_TEMP_RAM_EXIT_PPI FSP_TEMP_RAM_EXIT_PPI; > > + > > +/** > > + Silicon function for disabling temporary memory. > > + @param[in] TempRamExitParamPtr - Pointer to the TempRamExit > > parameters structure. > > + This structure is normally defined= in the Integration > > + Guide. If it is not defined in the= Integration Guide, > > + pass NULL. > > + @retval EFI_SUCCESS - Execution was completed successful= ly. > > + @retval Status - Error status reported by sub-funct= ions if > > implemented. > > +**/ > > +typedef > > +EFI_STATUS > > +(EFIAPI *FSP_TEMP_RAM_EXIT) ( > > + IN VOID *TempRamExitParamPtr > > + ); > > + > > +/// > > +/// This PPI provides function to disable temporary memory. > > +/// > > +struct _FSP_TEMP_RAM_EXIT_PPI { > > + FSP_TEMP_RAM_EXIT TempRamExit; > > +}; > > + > > +extern EFI_GUID gFspTempRamExitPpiGuid; > > + > > +#endif // _FSP_TEMP_RAM_EXIT_PPI_H_ > > -- > > 2.13.3.windows.1 >=20 >=20 >=20