From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.10396.1577962895148392555 for ; Thu, 02 Jan 2020 03:01:35 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: star.zeng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 03:01:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,386,1571727600"; d="scan'208";a="301940793" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 02 Jan 2020 03:01:34 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 03:01:34 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 03:01:33 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.202]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0439.000; Thu, 2 Jan 2020 19:01:32 +0800 From: "Zeng, Star" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Bi, Dandan" , "Zeng, Star" Subject: Re: [PATCH 3/6] MdeModulePkg/Smbios: Done measure Smbios multiple times. Thread-Topic: [PATCH 3/6] MdeModulePkg/Smbios: Done measure Smbios multiple times. Thread-Index: AQHVv6XIF8ppSKm2/0qSSeevZEF/ZKfXOJcw Date: Thu, 2 Jan 2020 11:01:32 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB048310404AB9D4@shsmsx102.ccr.corp.intel.com> References: <20191231064412.22988-1-jiewen.yao@intel.com> <20191231064412.22988-4-jiewen.yao@intel.com> In-Reply-To: <20191231064412.22988-4-jiewen.yao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: star.zeng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, December 31, 2019 2:44 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Bi, Dandan ; Zeng, Star > Subject: [PATCH 3/6] MdeModulePkg/Smbios: Done measure Smbios > multiple times. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2439 >=20 > In current implementation, the SMBIOS table is measured multiple time in > every readytoboot event. >=20 > This causes Smbios Table record appears multiple time in the TCG event lo= g > and confuses people. >=20 > This issue makes it hard to implement 800-155 reference measurement. >=20 > This patch closes the event to make sure Smbios is measured only once. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Star Zeng > Signed-off-by: Jiewen Yao > --- > .../Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 4 ++- > - > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen > tDxe.c > b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme > ntDxe.c > index 7b5d473146..5ec2aca095 100644 > --- > a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasuremen > tDxe.c > +++ > b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasureme > ntDxe.c > @@ -577,8 +577,8 @@ MeasureSmbiosTable ( > TableAddress, // HashData > TableLength // HashDataLen > ); > - if (EFI_ERROR (Status)) { > - return ; > + if (!EFI_ERROR (Status)) { > + gBS->CloseEvent (Event) ; > } > } >=20 > -- > 2.19.2.windows.1