From: "Zeng, Star" <star.zeng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Zeng, Star" <star.zeng@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier
Date: Tue, 4 Feb 2020 07:03:39 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB04831040538E09@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <15F020B7DFF40F56.10001@groups.io>
Sorry, the title is incorrect. Please see the thread with title " [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier"
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zeng,
> Star
> Sent: Tuesday, February 4, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match
> data type and format specifier
>
> Match data type and format specifier for printing.
> 1. Type cast ProcessorNumber and FeatureIndex to UINT32
> as %d only expects a UINT32.
> 2. Use %08x instead of %08lx for CacheControl to print Index
> as it is UINT32 type.
> 3. Use %016lx instead of %08lx for MemoryMapped to print
> (Index | LShiftU64 (HighIndex, 32)) as it is UINT64 type.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>
> Notes:
> v2: Address Laszlo's feedback in v1 at
> https://edk2.groups.io/g/devel/message/53663.
>
> .../CpuFeaturesInitialize.c | 24 +++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> index 0a4fcff033a3..fc96fb4372cf 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> @@ -430,8 +430,8 @@ DumpRegisterTableOnProcessor (
> DEBUG ((
> DebugPrintErrorLevel,
> "Processor: %04d: Index %04d, MSR : %08x, Bit Start: %02d, Bit
> Length: %02d, Value: %016lx\r\n",
> - ProcessorNumber,
> - FeatureIndex,
> + (UINT32) ProcessorNumber,
> + (UINT32) FeatureIndex,
> RegisterTableEntry->Index,
> RegisterTableEntry->ValidBitStart,
> RegisterTableEntry->ValidBitLength,
> @@ -442,8 +442,8 @@ DumpRegisterTableOnProcessor (
> DEBUG ((
> DebugPrintErrorLevel,
> "Processor: %04d: Index %04d, CR : %08x, Bit Start: %02d, Bit
> Length: %02d, Value: %016lx\r\n",
> - ProcessorNumber,
> - FeatureIndex,
> + (UINT32) ProcessorNumber,
> + (UINT32) FeatureIndex,
> RegisterTableEntry->Index,
> RegisterTableEntry->ValidBitStart,
> RegisterTableEntry->ValidBitLength,
> @@ -453,9 +453,9 @@ DumpRegisterTableOnProcessor (
> case MemoryMapped:
> DEBUG ((
> DebugPrintErrorLevel,
> - "Processor: %04d: Index %04d, MMIO : %08lx, Bit Start: %02d, Bit
> Length: %02d, Value: %016lx\r\n",
> - ProcessorNumber,
> - FeatureIndex,
> + "Processor: %04d: Index %04d, MMIO : %016lx, Bit Start: %02d,
> Bit Length: %02d, Value: %016lx\r\n",
> + (UINT32) ProcessorNumber,
> + (UINT32) FeatureIndex,
> RegisterTableEntry->Index | LShiftU64
> (RegisterTableEntry->HighIndex, 32),
> RegisterTableEntry->ValidBitStart,
> RegisterTableEntry->ValidBitLength,
> @@ -465,9 +465,9 @@ DumpRegisterTableOnProcessor (
> case CacheControl:
> DEBUG ((
> DebugPrintErrorLevel,
> - "Processor: %04d: Index %04d, CACHE: %08lx, Bit Start: %02d, Bit
> Length: %02d, Value: %016lx\r\n",
> - ProcessorNumber,
> - FeatureIndex,
> + "Processor: %04d: Index %04d, CACHE: %08x, Bit Start: %02d, Bit
> Length: %02d, Value: %016lx\r\n",
> + (UINT32) ProcessorNumber,
> + (UINT32) FeatureIndex,
> RegisterTableEntry->Index,
> RegisterTableEntry->ValidBitStart,
> RegisterTableEntry->ValidBitLength,
> @@ -478,8 +478,8 @@ DumpRegisterTableOnProcessor (
> DEBUG ((
> DebugPrintErrorLevel,
> "Processor: %04d: Index %04d, SEMAP: %s\r\n",
> - ProcessorNumber,
> - FeatureIndex,
> + (UINT32) ProcessorNumber,
> + (UINT32) FeatureIndex,
> mDependTypeStr[MIN ((UINT32)RegisterTableEntry->Value,
> InvalidDepType)]
> ));
> break;
> --
> 2.21.0.windows.1
>
>
>
next parent reply other threads:[~2020-02-04 7:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15F020B7DFF40F56.10001@groups.io>
2020-02-04 7:03 ` Zeng, Star [this message]
[not found] <15F020D73DC0C8D8.26520@groups.io>
2020-02-04 7:03 ` [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB04831040538E09@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox