* Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier [not found] <15F020B7DFF40F56.10001@groups.io> @ 2020-02-04 7:03 ` Zeng, Star 0 siblings, 0 replies; 2+ messages in thread From: Zeng, Star @ 2020-02-04 7:03 UTC (permalink / raw) To: devel@edk2.groups.io, Zeng, Star; +Cc: Dong, Eric, Ni, Ray, Laszlo Ersek Sorry, the title is incorrect. Please see the thread with title " [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier" > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zeng, > Star > Sent: Tuesday, February 4, 2020 2:57 PM > To: devel@edk2.groups.io > Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, > Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com> > Subject: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match > data type and format specifier > > Match data type and format specifier for printing. > 1. Type cast ProcessorNumber and FeatureIndex to UINT32 > as %d only expects a UINT32. > 2. Use %08x instead of %08lx for CacheControl to print Index > as it is UINT32 type. > 3. Use %016lx instead of %08lx for MemoryMapped to print > (Index | LShiftU64 (HighIndex, 32)) as it is UINT64 type. > > Cc: Eric Dong <eric.dong@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Laszlo Ersek <lersek@redhat.com> > Signed-off-by: Star Zeng <star.zeng@intel.com> > --- > > Notes: > v2: Address Laszlo's feedback in v1 at > https://edk2.groups.io/g/devel/message/53663. > > .../CpuFeaturesInitialize.c | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > index 0a4fcff033a3..fc96fb4372cf 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > @@ -430,8 +430,8 @@ DumpRegisterTableOnProcessor ( > DEBUG (( > DebugPrintErrorLevel, > "Processor: %04d: Index %04d, MSR : %08x, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index, > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -442,8 +442,8 @@ DumpRegisterTableOnProcessor ( > DEBUG (( > DebugPrintErrorLevel, > "Processor: %04d: Index %04d, CR : %08x, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index, > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -453,9 +453,9 @@ DumpRegisterTableOnProcessor ( > case MemoryMapped: > DEBUG (( > DebugPrintErrorLevel, > - "Processor: %04d: Index %04d, MMIO : %08lx, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + "Processor: %04d: Index %04d, MMIO : %016lx, Bit Start: %02d, > Bit Length: %02d, Value: %016lx\r\n", > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index | LShiftU64 > (RegisterTableEntry->HighIndex, 32), > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -465,9 +465,9 @@ DumpRegisterTableOnProcessor ( > case CacheControl: > DEBUG (( > DebugPrintErrorLevel, > - "Processor: %04d: Index %04d, CACHE: %08lx, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + "Processor: %04d: Index %04d, CACHE: %08x, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index, > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -478,8 +478,8 @@ DumpRegisterTableOnProcessor ( > DEBUG (( > DebugPrintErrorLevel, > "Processor: %04d: Index %04d, SEMAP: %s\r\n", > - ProcessorNumber, > - FeatureIndex, > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > mDependTypeStr[MIN ((UINT32)RegisterTableEntry->Value, > InvalidDepType)] > )); > break; > -- > 2.21.0.windows.1 > > > ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <15F020D73DC0C8D8.26520@groups.io>]
* Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier [not found] <15F020D73DC0C8D8.26520@groups.io> @ 2020-02-04 7:03 ` Zeng, Star 0 siblings, 0 replies; 2+ messages in thread From: Zeng, Star @ 2020-02-04 7:03 UTC (permalink / raw) To: devel@edk2.groups.io, Zeng, Star; +Cc: Dong, Eric, Ni, Ray, Laszlo Ersek Sorry, the title is incorrect. Please see the thread with title " [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier" > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zeng, > Star > Sent: Tuesday, February 4, 2020 3:00 PM > To: devel@edk2.groups.io > Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, > Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com> > Subject: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match > data type and format specifier > > Match data type and format specifier for printing. > 1. Type cast ProcessorNumber and FeatureIndex to UINT32 > as %d only expects a UINT32. > 2. Use %08x instead of %08lx for CacheControl to print Index > as it is UINT32 type. > 3. Use %016lx instead of %08lx for MemoryMapped to print > (Index | LShiftU64 (HighIndex, 32)) as it is UINT64 type. > > Cc: Eric Dong <eric.dong@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Laszlo Ersek <lersek@redhat.com> > Signed-off-by: Star Zeng <star.zeng@intel.com> > --- > > Notes: > v2: Address Laszlo's feedback in v1 at > https://edk2.groups.io/g/devel/message/53663. > > .../CpuFeaturesInitialize.c | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > index 0a4fcff033a3..fc96fb4372cf 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > @@ -430,8 +430,8 @@ DumpRegisterTableOnProcessor ( > DEBUG (( > DebugPrintErrorLevel, > "Processor: %04d: Index %04d, MSR : %08x, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index, > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -442,8 +442,8 @@ DumpRegisterTableOnProcessor ( > DEBUG (( > DebugPrintErrorLevel, > "Processor: %04d: Index %04d, CR : %08x, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index, > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -453,9 +453,9 @@ DumpRegisterTableOnProcessor ( > case MemoryMapped: > DEBUG (( > DebugPrintErrorLevel, > - "Processor: %04d: Index %04d, MMIO : %08lx, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + "Processor: %04d: Index %04d, MMIO : %016lx, Bit Start: %02d, > Bit Length: %02d, Value: %016lx\r\n", > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index | LShiftU64 > (RegisterTableEntry->HighIndex, 32), > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -465,9 +465,9 @@ DumpRegisterTableOnProcessor ( > case CacheControl: > DEBUG (( > DebugPrintErrorLevel, > - "Processor: %04d: Index %04d, CACHE: %08lx, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > - ProcessorNumber, > - FeatureIndex, > + "Processor: %04d: Index %04d, CACHE: %08x, Bit Start: %02d, Bit > Length: %02d, Value: %016lx\r\n", > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > RegisterTableEntry->Index, > RegisterTableEntry->ValidBitStart, > RegisterTableEntry->ValidBitLength, > @@ -478,8 +478,8 @@ DumpRegisterTableOnProcessor ( > DEBUG (( > DebugPrintErrorLevel, > "Processor: %04d: Index %04d, SEMAP: %s\r\n", > - ProcessorNumber, > - FeatureIndex, > + (UINT32) ProcessorNumber, > + (UINT32) FeatureIndex, > mDependTypeStr[MIN ((UINT32)RegisterTableEntry->Value, > InvalidDepType)] > )); > break; > -- > 2.21.0.windows.1 > > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-04 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <15F020B7DFF40F56.10001@groups.io>
2020-02-04 7:03 ` [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier Zeng, Star
[not found] <15F020D73DC0C8D8.26520@groups.io>
2020-02-04 7:03 ` Zeng, Star
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox