From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.18501.1581317536186478124 for ; Sun, 09 Feb 2020 22:52:16 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: star.zeng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 22:52:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,424,1574150400"; d="scan'208";a="226058708" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 09 Feb 2020 22:52:15 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 22:52:15 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 22:52:14 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.126]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.97]) with mapi id 14.03.0439.000; Mon, 10 Feb 2020 14:52:12 +0800 From: "Zeng, Star" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues Thread-Topic: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues Thread-Index: AQHV38WybQ47WGPt7kejQxJPa58s26gT/Zzg Date: Mon, 10 Feb 2020 06:52:12 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483104054858B@shsmsx102.ccr.corp.intel.com> References: <20200210035329.19432-1-chasel.chiu@intel.com> In-Reply-To: <20200210035329.19432-1-chasel.chiu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmRkNjhhZDYtY2JkOC00ZjI4LTkwMTQtODBlMzIwOTEzMWRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNURic1lONmI3ZXh2aWdib091Q29USW1VR3E0SkNsamg2N3E1NkZNOVoyNSt4WTZMUnE4dDMyYmlWVWMrRVNtbiJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: star.zeng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng > -----Original Message----- > From: Chiu, Chasel > Sent: Monday, February 10, 2020 11:53 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues >=20 > GenCfgOpt.py: > Issue was: invalid_operation: Invalid operation on null-like value "Base"= . > Fixed it by initializing Base to 0 before entering while loop. >=20 > SplitFspBin.py: > Issues were: > 1. copy_paste_error: PeOptHdr vs PePlusOptHdr. > 2. invalid_operation: Invalid operation on null-like value "roffset". > 3. invalid_operation: Invalid operation on null-like value "rsize". > Fixed them by initializing roffset and rsize as PE32 image type and overr= iding > them when PE32+ header found. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu >=20 > Chasel Chiu (2): > IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues. > IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues. >=20 > IntelFsp2Pkg/Tools/GenCfgOpt.py | 3 ++- > IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) >=20 > -- > 2.13.3.windows.1