From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7EC4A1A1E28 for ; Thu, 27 Oct 2016 08:01:25 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP; 27 Oct 2016 08:01:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,553,1473145200"; d="scan'208";a="24439416" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 27 Oct 2016 08:01:06 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 27 Oct 2016 08:01:06 -0700 Received: from fmsmsx120.amr.corp.intel.com ([169.254.15.251]) by FMSMSX113.amr.corp.intel.com ([169.254.13.12]) with mapi id 14.03.0248.002; Thu, 27 Oct 2016 08:01:05 -0700 From: "Dong, Guo" To: "Ma, Maurice" CC: "Agyeman, Prince" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib Thread-Index: AQHSL+oK3F8cpdS0aEevTwFMECBVsqC8EnEAgABTHPA= Date: Thu, 27 Oct 2016 15:01:04 +0000 Message-ID: <0DE6ECBAEEB99B4DA9564FF580F3580A0D2C530A@fmsmsx120.amr.corp.intel.com> References: <5faf51db74745f86a21daaea9873a930282e9fe7.1477528432.git.guo.dong@intel.com> <7AAC936950815649B5F88FAE785306C284176D6A@ORSMSX113.amr.corp.intel.com> In-Reply-To: <7AAC936950815649B5F88FAE785306C284176D6A@ORSMSX113.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGMxYzM5NDktZTg1Ni00NDJhLWE2N2MtZWZiZWFjM2M0OGM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVCQVl3WkVkZEhORHZPRTh0dXdwNTlqOFVJc21kUjQ3dFp0SHpRMzJcLzhZPSJ9 x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 15:01:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Maurice, Thank you for the comments. I have updated patch to add EFIAPI to all the APIs in CbParseLib. Thanks, Guo -----Original Message----- From: Ma, Maurice=20 Sent: Wednesday, October 26, 2016 8:02 PM To: Dong, Guo Cc: Agyeman, Prince ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from= CbParseLib Guo, I think it is better to add "EFIAPI" to force the calling convention. Thanks Maurice -----Original Message----- From: Dong, Guo Sent: Wednesday, October 26, 2016 5:35 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbP= arseLib CbPlatformSupportLib might use FindCbTag() API to parse platform specific i= nformation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong Reviewed-by: Maurice Ma --- CorebootModulePkg/Include/Library/CbParseLib.h | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/CorebootModulePkg/Include/Library/CbParseLib.h b/CorebootModul= ePkg/Include/Library/CbParseLib.h index 064baf3..e1fda7e 100644 --- a/CorebootModulePkg/Include/Library/CbParseLib.h +++ b/CorebootModulePkg/Include/Library/CbParseLib.h @@ -2,7 +2,7 @@ This library will parse the coreboot table in memory and extract those r= equired information. =20 - Copyright (c) 2014, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 - 2016, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -18,6 +18,23 @@ typedef RETURN_STATUS \ (*CB_MEM_INFO_CALLBACK) (UINT64 Base, UINT64 Size, UINT32 Type, VO= ID *Param); =20 /** + Find coreboot record with given Tag from the memory Start in 4096=20 + bytes range. + + @param Start The start memory to be searched in + @param Tag The tag id to be found + + @retval NULL The Tag is not found. + @retval Others The poiter to the record found. + +**/ +VOID * +FindCbTag ( + IN VOID *Start, + IN UINT32 Tag + ); + +/** Acquire the memory information from the coreboot table in memory. =20 @param MemInfoCallback The callback routine -- 2.7.0.windows.1