From: "Guo Dong" <guo.dong@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"lersek@redhat.com" <lersek@redhat.com>
Subject: Re: [PATCH 3/5] UefiPayloadPkg: remove EnterS3WithImmediateWake () from ResetSystemLib
Date: Tue, 7 Jan 2020 16:32:12 +0000 [thread overview]
Message-ID: <0DE6ECBAEEB99B4DA9564FF580F3580A4B60DD35@fmsmsx120.amr.corp.intel.com> (raw)
In-Reply-To: <20200106151310.12322-4-ard.biesheuvel@linaro.org>
Reviewed-by: Guo Dong <guo.dong@intel.com>
> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Monday, January 6, 2020 8:13 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>;
> You, Benjamin <benjamin.you@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> lersek@redhat.com; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [PATCH 3/5] UefiPayloadPkg: remove EnterS3WithImmediateWake ()
> from ResetSystemLib
>
> EnterS3WithImmediateWake () no longer has any callers, so remove it from
> ResetSystemLib.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> b/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> index 3fe3c805afe0..2e4b7fe59261 100644
> --- a/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -131,24 +131,6 @@ ResetShutdown (
> ASSERT (FALSE);
> }
>
> -/**
> - Calling this function causes the system to enter a power state for capsule
> - update.
> -
> - Reset update should not return, if it returns, it means the system does
> - not support capsule update.
> -
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> - VOID
> - )
> -{
> - AcpiPmControl (5);
> - ASSERT (FALSE);
> -}
> -
> /**
> This function causes a systemwide reset. The exact type of the reset is
> defined by the EFI_GUID that follows the Null-terminated Unicode string
> passed
> --
> 2.20.1
next prev parent reply other threads:[~2020-01-07 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:13 [PATCH 0/5] remove EnterS3WithImmediateWake () from ResetSystemLib Ard Biesheuvel
2020-01-06 15:13 ` [PATCH 1/5] MdeModulePkg: " Ard Biesheuvel
2020-01-08 18:51 ` Ard Biesheuvel
2020-01-09 12:56 ` Laszlo Ersek
2020-01-10 1:21 ` Ni, Ray
2020-01-10 6:46 ` Ard Biesheuvel
2020-01-06 15:13 ` [PATCH 2/5] PcAtChipsetPkg: " Ard Biesheuvel
2020-01-06 15:13 ` [PATCH 3/5] UefiPayloadPkg: " Ard Biesheuvel
2020-01-07 16:32 ` Guo Dong [this message]
2020-01-06 15:13 ` [PATCH 4/5] OvmfPkg: " Ard Biesheuvel
2020-01-06 16:29 ` Laszlo Ersek
2020-01-06 15:13 ` [PATCH 5/5] ArmVirtPkg: " Ard Biesheuvel
2020-01-06 16:29 ` Laszlo Ersek
2020-01-07 2:05 ` [PATCH 0/5] " Ni, Ray
2020-01-10 7:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DE6ECBAEEB99B4DA9564FF580F3580A4B60DD35@fmsmsx120.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox