From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by mx.groups.io with SMTP id smtpd.web11.7992.1578414733631223339
 for <devel@edk2.groups.io>;
 Tue, 07 Jan 2020 08:32:13 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: guo.dong@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
  by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 08:32:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,406,1571727600"; 
   d="scan'208";a="271563271"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by FMSMGA003.fm.intel.com with ESMTP; 07 Jan 2020 08:32:13 -0800
Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 7 Jan 2020 08:32:12 -0800
Received: from fmsmsx120.amr.corp.intel.com ([169.254.15.173]) by
 fmsmsx158.amr.corp.intel.com ([169.254.15.85]) with mapi id 14.03.0439.000;
 Tue, 7 Jan 2020 08:32:12 -0800
From: "Guo Dong" <guo.dong@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Ma, Maurice" <maurice.ma@intel.com>, "You, Benjamin"
	<benjamin.you@intel.com>, "Ni, Ray" <ray.ni@intel.com>, "Gao, Liming"
	<liming.gao@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>, "lersek@redhat.com"
	<lersek@redhat.com>
Subject: Re: [PATCH 3/5] UefiPayloadPkg: remove EnterS3WithImmediateWake () from ResetSystemLib
Thread-Topic: [PATCH 3/5] UefiPayloadPkg: remove EnterS3WithImmediateWake ()
 from ResetSystemLib
Thread-Index: AQHVxKPYF5YHbH60BkaYdQzNIOSR6KffZnzg
Date: Tue, 7 Jan 2020 16:32:12 +0000
Message-ID: <0DE6ECBAEEB99B4DA9564FF580F3580A4B60DD35@fmsmsx120.amr.corp.intel.com>
References: <20200106151310.12322-1-ard.biesheuvel@linaro.org>
 <20200106151310.12322-4-ard.biesheuvel@linaro.org>
In-Reply-To: <20200106151310.12322-4-ard.biesheuvel@linaro.org>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGU2ODI1ODgtYjJjOS00NDk4LTkyNDctNjliMGZlMGU4MzMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidVU5aG1IUyt2SzBFUDJZazNyUlJzbHhSSllyV1VpZTVSaFVCMnU4YVRwS1VFbzFSWGxqQkRoUnlMeFBuVDFXZiJ9
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.1.200.107]
MIME-Version: 1.0
Return-Path: guo.dong@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Guo Dong <guo.dong@intel.com>

> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Monday, January 6, 2020 8:13 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>;
> You, Benjamin <benjamin.you@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> lersek@redhat.com; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [PATCH 3/5] UefiPayloadPkg: remove EnterS3WithImmediateWake ()
> from ResetSystemLib
>=20
> EnterS3WithImmediateWake () no longer has any callers, so remove it from
> ResetSystemLib.
>=20
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c | 18 ------------=
------
>  1 file changed, 18 deletions(-)
>=20
> diff --git a/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> b/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> index 3fe3c805afe0..2e4b7fe59261 100644
> --- a/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -131,24 +131,6 @@ ResetShutdown (
>    ASSERT (FALSE);
>  }
>=20
> -/**
> -  Calling this function causes the system to enter a power state for cap=
sule
> -  update.
> -
> -  Reset update should not return, if it returns, it means the system doe=
s
> -  not support capsule update.
> -
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> -  VOID
> -  )
> -{
> -  AcpiPmControl (5);
> -  ASSERT (FALSE);
> -}
> -
>  /**
>    This function causes a systemwide reset. The exact type of the reset i=
s
>    defined by the EFI_GUID that follows the Null-terminated Unicode strin=
g
> passed
> --
> 2.20.1