From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ma1-aaemail-dr-lapp03.apple.com (ma1-aaemail-dr-lapp03.apple.com [17.171.2.72]) by mx.groups.io with SMTP id smtpd.web09.903.1617599405193570083 for ; Sun, 04 Apr 2021 22:10:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=MqTybdKT; spf=pass (domain: apple.com, ip: 17.171.2.72, mailfrom: afish@apple.com) Received: from pps.filterd (ma1-aaemail-dr-lapp03.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp03.apple.com (8.16.0.42/8.16.0.42) with SMTP id 13553v8a053398; Sun, 4 Apr 2021 22:10:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : content-transfer-encoding : from : mime-version : subject : date : message-id : references : cc : in-reply-to : to; s=20180706; bh=e3Fo9UAEPldx4OsXDr3p8vKCwMddN9GxWCgDnYuoAew=; b=MqTybdKTeuHO7XjFKeIax3NuCWCc3D0j8nImc8KkCYlmooJ8gJaTbzwvkNpww+EXnGuE bkX4cExjOAmM6l6mqfydEc13SRbaeas0vv3MAJM0ux1rCYJx+H0PP3q0qQ5th4Faicwv 9WR/7uN6nLpUj5qxQYr7kv/VB+Nu9xUnNgE/4fQbsEESyfhDRV4ueqSINMAHxT8g1m9h 5B4PC8pXUt3jieY6LQzy0kAJQx0zdaqRQc68acOtqkq6wTM1lnFLsy7r95Ne09rRf2YM EzF/qhvaaaP+1jwBMyaj9OFkX/578czbKDREoTDl/8mYEqRDz/U0gwuDPEuy7GQadTeX rg== Received: from rn-mailsvcp-mta-lapp02.rno.apple.com (rn-mailsvcp-mta-lapp02.rno.apple.com [10.225.203.150]) by ma1-aaemail-dr-lapp03.apple.com with ESMTP id 37q2rcetab-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Sun, 04 Apr 2021 22:10:04 -0700 Received: from rn-mailsvcp-mmp-lapp03.rno.apple.com (rn-mailsvcp-mmp-lapp03.rno.apple.com [17.179.253.16]) by rn-mailsvcp-mta-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.7.20201203 64bit (built Dec 3 2020)) with ESMTPS id <0QR200NZVROS88A0@rn-mailsvcp-mta-lapp02.rno.apple.com>; Sun, 04 Apr 2021 22:10:04 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp03.rno.apple.com by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.7.20201203 64bit (built Dec 3 2020)) id <0QR200H00RHIQU00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Sun, 04 Apr 2021 22:10:04 -0700 (PDT) X-Va-A: X-Va-T-CD: b2a6e213b1e93bac3561a11ee6934d40 X-Va-E-CD: 4730c80ee67030d4f2c83e40b4ab0357 X-Va-R-CD: cb89099c14db325e6e9dc63a22e96e3a X-Va-CD: 0 X-Va-ID: a650b357-b003-4aaf-aae6-6a9d45cbf345 X-V-A: X-V-T-CD: b2a6e213b1e93bac3561a11ee6934d40 X-V-E-CD: 4730c80ee67030d4f2c83e40b4ab0357 X-V-R-CD: cb89099c14db325e6e9dc63a22e96e3a X-V-CD: 0 X-V-ID: 60ffbf8b-df76-467a-ab97-21a522e5e272 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-04-05_02:2021-04-01,2021-04-05 signatures=0 Received: from [17.11.152.232] (unknown [17.11.152.232]) by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.7.20201203 64bit (built Dec 3 2020)) with ESMTPSA id <0QR200L4CRORQY00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Sun, 04 Apr 2021 22:10:03 -0700 (PDT) From: "Andrew Fish" MIME-version: 1.0 (1.0) Subject: Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021) Date: Sun, 04 Apr 2021 22:10:02 -0700 Message-id: <0EB40B5D-C250-48BD-885C-A859205BC20A@apple.com> References: Cc: devel@edk2.groups.io, nathaniel.l.desimone@intel.com, Rafael Rodrigues Machado In-reply-to: To: Ethin Probst X-Mailer: iPhone Mail (18D70) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-04-05_02:2021-04-01,2021-04-05 signatures=0 Content-type: multipart/alternative; boundary=Apple-Mail-11020D31-90D3-4906-9C26-8CAEA0F94814 Content-transfer-encoding: 7bit --Apple-Mail-11020D31-90D3-4906-9C26-8CAEA0F94814 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable CPPFLAGS might be your issue. Assuming VFR is failing. It is one of the onl= y C++ tools. See the end of: https://github.com/tianocore/edk2/blob/master/BaseTools/Source/C/Makefiles= /ms.common It would be good to attach this failure to the BZ too > On Apr 4, 2021, at 9:43 PM, Ethin Probst wrote= : >=20 > =EF=BB=BFI can't run edksetup.bat rebuild. The system is set to treat wa= rnings > as errors, and the build tools have warnings within them, and so MSVC > bails out. >=20 >> On 4/4/21, Andrew Fish via groups.io wrot= e: >> Ethin I=E2=80=99m not sure what issue you are hitting with VFR? When yo= u built the C >> build tools it should have built the VFR compiler that matches the code= ? >>=20 >> Did you run edksetup.bat Rebuild? >>> On Mar 31, 2021, at 10:05 PM, Ethin Probst >>> wrote: >>>=20 >>> =EF=BB=BFHello there, >>>=20 >>> Some good advice, and thank you! I might add it to the other virtIO* >>> drivers if I can figure out a good template for that. >>>=20 >>> One thing I'm running into right now is that my build setup is >>> currently unable to build MdeModulePkg (which is required to build >>> OVMF, according to the readme). I've reported it on the bugzilla; its >>> issue 3289. This doesn't appear to occur on Linux, however, which is >>> odd. >>>=20 >>> Are there any suggestions that you guys have for improving my >>> proposal? I didn't want to write too much or go overboard, like >>> explaining how the sound driver would work and such, since I assumed >>> -- while writing it -- that anyone who wanted to know those inner >>> details would go read the VirtIO specification. But I'd appreciate any >>> extra feedback before I submit my final version; I haven't made any >>> changes since my initial proposal as of yet. >>>=20 >>>> On 3/31/21, Nate DeSimone wrote: >>>> Another option is to put the protocol definition in MdeModulePkg and = mark >>>> it >>>> with the EDKII_ prefix. For my last =E2=80=9Ccode first=E2=80=9D UEFI= spec contribution >>>> I >>>> did this with the PPI that added up getting added. >>>>=20 >>>> Thanks, >>>> Nate >>>>=20 >>>> From: on behalf of "Andrew Fish via groups.io" >>>> >>>> Reply-To: "devel@edk2.groups.io" , >>>> "afish@apple.com" >>>> >>>> Date: Tuesday, March 30, 2021 at 10:54 PM >>>> To: edk2-devel-groups-io , >>>> "harlydavidsen@gmail.com" >>>> >>>> Cc: Rafael Rodrigues Machado >>>> Subject: Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021) >>>>=20 >>>>=20 >>>>=20 >>>> On Mar 30, 2021, at 5:01 PM, Ethin Probst >>>> > wrote: >>>>=20 >>>> I'm wondering where exactly I should add the VirtIO sound protocol. I >>>> just familiarized myself with the build system and am about to test i= t >>>> by building OVMF if possible, but I'm wondering where I should >>>> actually put the protocol and all that stuff. Maybe there's >>>> documentation I've missed as well. >>>>=20 >>>> Ethin, >>>>=20 >>>> For the driver I=E2=80=99d match the patter of OVMF [1] and use >>>> OvmfPkg/VirtioSoundDxe/. Maybe even use one of the other drivers as a >>>> template. >>>>=20 >>>> The protocol is more of a public thing. I think eventually we would l= ike >>>> to >>>> publish the protocol in the UEFI Spec (I can help with that part) and >>>> that >>>> would mean we put the Protocol definition in MdePkg/Include/Protocol,= but >>>> we >>>> don=E2=80=99t want to do that before it is standardized as that cause= s >>>> compatibility >>>> issues. So this is a =E2=80=9Ccode first project=E2=80=9D (code proto= type and then >>>> contribute to the UEFI Forum for inclusion in the specification) so w= e >>>> need >>>> to follow some code first rules that I don=E2=80=99t remember of the = top of my >>>> head? >>>> So why not start out the protocol definition OvmfPkg/Include/Protocol= . >>>> You >>>> can also add a test application looks like you can just use the root = [2] >>>> of >>>> OVMF for that. That way the project is not blocked. >>>>=20 >>>> We can have a conversation on the mailing list about better places to >>>> put >>>> stuff, and it should be easy enough to move stuff around if everythin= g >>>> else >>>> is working. >>>>=20 >>>> [1] find OvmfPkg -iname '*Virtio*.inf' >>>> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf >>>> OvmfPkg/VirtioScsiDxe/VirtioScsi.inf >>>> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf >>>> OvmfPkg/Library/VirtioLib/VirtioLib.inf >>>> OvmfPkg/VirtioGpuDxe/VirtioGpu.inf >>>> OvmfPkg/VirtioBlkDxe/VirtioBlk.inf >>>> OvmfPkg/Virtio10Dxe/Virtio10.inf >>>> OvmfPkg/VirtioNetDxe/VirtioNet.inf >>>> OvmfPkg/VirtioRngDxe/VirtioRng.inf >>>>=20 >>>>=20 >>>> [2] /Volumes/Case/edk2-github/OvmfPkg>git grep APPLICATION -- *.inf | >>>> grep >>>> MODULE_TYPE >>>> EnrollDefaultKeys/EnrollDefaultKeys.inf:13: MODULE_TYPE >>>> =3D UEFI_APPLICATION >>>>=20 >>>> Thanks, >>>>=20 >>>> Andrew Fish >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> On 3/30/21, Ethin Probst via groups.io >>>> > >>>> wrote: >>>>=20 >>>> I agree. Plus, it gives me a chance to finally learn the EDK2 build >>>> system and how it works! I've been working on a hobby OS as a side >>>> project and, though learning from other code examples from OSes is >>>> fun, I have to say that learning from the firmware code like from >>>> SeaBIOS has been some of the most enlightening and interesting times >>>> thus far. >>>> Thanks for the link to your code, Rafael; once I get virtIO support >>>> in, I can work on HDA support, though I might tackle USB support >>>> second and HDA third. We'll see, but VirtIO definitely is coming >>>> first. >>>>=20 >>>> As I said before, I look forward to working with all of you wonderful >>>> people! >>>>=20 >>>> On 3/30/21, Rafael Rodrigues Machado >>>> > >>>> wrote: >>>>=20 >>>> This would be amazing so people can continue my work related to >>>> accessibility at BIOS. Something desired by the blind people since th= e >>>> 90's >>>> Just for reference, this is what I have done: >>>>=20 >>>> https://github.com/RafaelRMachado/Msc_UefiHda_PreOs_Accessibility >>>>=20 >>>> Thanks >>>> Rafael >>>>=20 >>>> Em seg, 29 de mar de 2021 20:24, Ethin Probst >>>> escreveu: >>>>=20 >>>>=20 >>>> Hello everyone, >>>>=20 >>>> This is the first time I've ever contributed to EDK2. As part of GSoC >>>> 2021, I have submitted a proposal to implement a UEFI audio output >>>> protocol that will utilize the VirtIO sound driver. I've already >>>> submitted a draft proposal, and apologize if I've done things out of >>>> order. This is my first time doing GSoC 2021, and contributing to EDK= 2 >>>> felt like a really fun thing to do! >>>>=20 >>>> I look forward to working with you guys on this and any future projec= ts! >>>> :-) >>>>=20 >>>> -- >>>> Signed, >>>> Ethin D. Probst >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> -- >>>> Signed, >>>> Ethin D. Probst >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> -- >>>> Signed, >>>> Ethin D. Probst >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>=20 >>>=20 >>> -- >>> Signed, >>> Ethin D. Probst >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >=20 >=20 > --=20 > Signed, > Ethin D. Probst --Apple-Mail-11020D31-90D3-4906-9C26-8CAEA0F94814 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
CPPFLAGS might be your issue. Ass= uming VFR is failing. It is one of the only C++ tools.

=
See the end of:
https://github.com/tianocor= e/edk2/blob/master/BaseTools/Source/C/Makefiles/ms.common

It wou= ld be good to attach this failure to the BZ too


On Apr 4, 2021, at 9:43 = PM, Ethin Probst <harlydavidsen@gmail.com> wrote:

=EF=BB=BFI can't ru= n edksetup.bat rebuild. The system is set to treat warnings
as errors, and the build tools have warnings within them, and so MSVC
bails out.

On 4/4/21, Andrew F= ish via groups.io <afish=3Dapple.com@groups.io> wrote:
Ethin I=E2=80=99m not sure what issue you are h= itting with VFR? When you built the C
build tools it should have built the VFR compiler that ma= tches the code?

Did you run edksetup.ba= t Rebuild?
On Mar 31, 2021, at 10:05 PM, Ethin Probst <harlydavids= en@gmail.com>
wrote:

=EF=BB=BFHello there,

Some go= od advice, and thank you! I might add it to the other virtIO*
= drivers if I can figure out a good template for that.

One thing I'm running into right now is that my bui= ld setup is
<= blockquote type=3D"cite">currently unable to build MdeModulePkg (whic= h is required to build
OVMF, according to the readme). = I've reported it on the bugzilla; its
<= blockquote type=3D"cite">
issue 3289. This d= oesn't appear to occur on Linux, however, which is
<= /blockquote>
odd.<= /span>

Are there any suggestions that you g= uys have for improving my
proposal? I didn't want to wri= te too much or go overboard, like
explaining how the sou= nd driver would work and such, since I assumed
-- while = writing it -- that anyone who wanted to know those inner
details would go read the VirtIO specification. But I'd appreciate any
extra feedback before I submit my final version; I haven't= made any
changes since my initial proposal as of yet.

On 3/31/21,= Nate DeSimone <nathaniel.l.desimone@intel.com> wrote:
Another option is to put the pr= otocol definition in MdeModulePkg and mark
it
with the EDKII_ prefix. For my last =E2=80=9Ccode first=E2=80= =9D UEFI spec contribution
I
did = this with the PPI that added up getting added.

Thanks,
<= blockquote type=3D"cite">
Nate

From: <devel@edk2= .groups.io> on behalf of "Andrew Fish via groups.io"
<afish=3Dapple.com@groups.io><= /span>
=
Reply-To: "devel@= edk2.groups.io" <devel@edk2.groups.io>,
"afish@apple.com"
<afish@apple.com>
Date: Tuesday, March 30, 2021 at 10:54= PM
To: edk2-deve= l-groups-io <devel@edk2.groups.io>,
"harlydavidsen@gmail.com"
<= /blockquote>
<harlydavidsen@gmail.com>
Cc: Rafael Rodrigues Macha= do <rafaelrodrigues.machado@gmail.com>
Subject: Re: [edk2-devel] VirtIO Sound Driver (= GSoC 2021)



<= /blockquote>
On Mar 30, 2021, at 5:01 PM, Ethin Probst
<harlydavidsen@gmail.com&l= t;mailto:harlydavidsen@gmail.com>> wrote:
<= blockquote type=3D"cite">
I'm wondering where exactly I should add the VirtIO sound = protocol. I
just = familiarized myself with the build system and am about to test it
by building OVMF if possib= le, but I'm wondering where I should
actually put the protocol and all that stuff. Maybe the= re's
documentatio= n I've missed as well.
=
Ethin,

For the driver I=E2=80=99d match the= patter of OVMF [1] and use
OvmfPkg/VirtioSoundDxe/. Maybe even use one of the other drivers= as a
template.
<= blockquote type=3D"cite">

The protocol is more of a public= thing. I think eventually we would like
to
publish the protocol in the UEFI Spec (I can help with that part)= and
that<= br>
would mean we put the Pr= otocol definition in MdePkg/Include/Protocol, but
we
don=E2=80=99t want to do that before it is standardized = as that causes
co= mpatibility
issue= s. So this is a =E2=80=9Ccode first project=E2=80=9D (code prototype and th= en
contribute to = the UEFI Forum for inclusion in the specification) so we
need
<= blockquote type=3D"cite">to follow some code first rules that I don= =E2=80=99t remember of the top of my
<= /blockquote>
head?
So why not start out the protocol definition OvmfPkg/Include/Prot= ocol.
You<= br>
can also add a test appl= ication looks like you can just use the root [2]
=
of
OVMF for that. That way the project is not blocked.

We can have a conversation on the mail= ing list about better places to
put
stuff, and it should be easy enough to move stuff around if everything<= /span>
=
else
is working.

[1] find OvmfPkg  -iname '*Virtio*.inf'
OvmfPkg/VirtioPciDev= iceDxe/VirtioPciDeviceDxe.inf
OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
OvmfPkg/Library/VirtioMmioDeviceLib/Virtio= MmioDeviceLib.inf
OvmfPkg/Library/VirtioLib/VirtioLib.inf
OvmfPkg/VirtioGpuDxe/VirtioGpu.inf
OvmfPkg/VirtioBlkDxe/VirtioBlk.i= nf
OvmfPkg/Virtio= 10Dxe/Virtio10.inf
OvmfPkg/VirtioNetDxe/VirtioNet.inf
OvmfPkg/VirtioRngDxe/VirtioRng.inf

=

= [2] /Volumes/Case/edk2-github/OvmfPkg>git grep APPLICATION -- *.in= f |
grep
MODULE_TYPE
EnrollDefaultKeys/EnrollDefaul= tKeys.inf:13:  MODULE_TYPE
=3D UEFI_APPLICATION
<= /blockquote>

<= span>Thanks,

Andrew Fish

<= /blockquote>



On 3/30/21, Et= hin Probst via groups.io<http://groups.io/>
<harlydavidsen=3Dgmail.com@groups.io<= ;mailto:harlydavidsen=3Dgmail.com@groups.io>>
=
wrote:

=
I agree. Plus, it gives me a chance to finally learn the EDK2 buil= d
system and how = it works! I've been working on a hobby OS as a side
=
project and, though learning from other = code examples from OSes is
fun, I have to say that learning from the firmware code like from=
SeaBIOS has been= some of the most enlightening and interesting times
thus far.
Thanks for the link to your code, Rafael; once= I get virtIO support
<= span>in, I can work on HDA support, though I might tackle USB support
second and HDA third. = We'll see, but VirtIO definitely is coming
first.

As I said before, I look forward to working with all of you wonderful
people!

On 3/30/21, Rafael Rodrigues Machado
<rafaelrodrigues.machad= o@gmail.com<mailto:rafaelrodrigues.machado@gmail.com>>
<= /blockquote>
wrote:

<= /blockquote>
This would be amazing so people can continue my work r= elated to
access= ibility at BIOS. Something desired by the blind people since the
=
90's
Just for reference, this is what I have= done:
https://github.com/RafaelR= Machado/Msc_UefiHda_PreOs_Accessibility

Thanks
Raf= ael

Em seg, 29 de mar de 2021 20:= 24, Ethin Probst <harlydavidsen@gmail.com>
=
escreveu:

=

Hello = everyone,

This is the first time= I've ever contributed to EDK2. As part of GSoC
<= blockquote type=3D"cite">2021, I have submitted a proposal to impleme= nt a UEFI audio output
= protocol that will utilize the VirtIO sound driver. I've already
submitted a draft pro= posal, and apologize if I've done things out of
<= blockquote type=3D"cite">order. This is my first time doing GSoC 2021= , and contributing to EDK2
felt like a really fun thing to do!

I look forward to working with you guys on this and any future= projects!
:-)

--
Signed,
Ethin D. Probst








--
Signed,
<= /blockquote>
Ethin D. Probst



<= /blockquote>

<= blockquote type=3D"cite">


--
Signed,
Ethin D. Probst




<= /blockquote>

<= blockquote type=3D"cite">






=
--
Signed,
= Ethin D. Probst





=


--
Si= gned,
Ethin D. Probst
--Apple-Mail-11020D31-90D3-4906-9C26-8CAEA0F94814--