From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=wY507q2N; spf=pass (domain: apple.com, ip: 17.151.62.68, mailfrom: afish@apple.com) Received: from nwk-aaemail-lapp03.apple.com (nwk-aaemail-lapp03.apple.com [17.151.62.68]) by groups.io with SMTP; Mon, 26 Aug 2019 14:59:36 -0700 Received: from pps.filterd (nwk-aaemail-lapp03.apple.com [127.0.0.1]) by nwk-aaemail-lapp03.apple.com (8.16.0.27/8.16.0.27) with SMTP id x7QLvml5027562; Mon, 26 Aug 2019 14:59:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=sender : from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=92A7LhJvbBczcXiz3In4delty46HWFEcFsx98k94BQ4=; b=wY507q2Nr3X4NrPaIBl4Nhp21CYFEokEiY6PNTTgytlsuWz9IN6D8J+vBlOgnC3tMZvn AQITVpF+Ws2nwE14m+bassIld8NnQDN4Vw9k2blIsCAVQMfwGMH7CDmkuP1gtvdrkene YyUdCk9hNOPVvqBTg1iU7OjXwRGz/pFgDY/kVMYZRqaO7kf1u62S4UUJOTnMCVuw232v +3bpRlYH6QeBWLl7tyJVGrrvPW3qfqCyKGWkg7H3gADSUB6GI2JFNbjhX77dYO7rqStq ABCAhFocRaLboFAjzatsRt7UoWAzrqwU7qHmnCbn6fW3RRl365qVF/RFqVfTA/Ovpt8q CA== Received: from ma1-mtap-s03.corp.apple.com (ma1-mtap-s03.corp.apple.com [17.40.76.7]) by nwk-aaemail-lapp03.apple.com with ESMTP id 2uknfn0fyn-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 26 Aug 2019 14:59:33 -0700 Received: from nwk-mmpp-sz09.apple.com (nwk-mmpp-sz09.apple.com [17.128.115.80]) by ma1-mtap-s03.corp.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPS id <0PWV00MQ76F5DA10@ma1-mtap-s03.corp.apple.com>; Mon, 26 Aug 2019 14:59:32 -0700 (PDT) Received: from process_milters-daemon.nwk-mmpp-sz09.apple.com by nwk-mmpp-sz09.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) id <0PWV00D0065IX400@nwk-mmpp-sz09.apple.com>; Mon, 26 Aug 2019 14:59:32 -0700 (PDT) X-Va-A: X-Va-T-CD: 281f8fa03638b888ab0035439e9fe9bb X-Va-E-CD: 7be8c6f9a457bfa738490035d2e183d8 X-Va-R-CD: 28cfb432f63ff0d30657baef1c1a3c05 X-Va-CD: 0 X-Va-ID: 1b34ee10-c88d-46cd-a900-104429c0901c X-V-A: X-V-T-CD: 281f8fa03638b888ab0035439e9fe9bb X-V-E-CD: 7be8c6f9a457bfa738490035d2e183d8 X-V-R-CD: 28cfb432f63ff0d30657baef1c1a3c05 X-V-CD: 0 X-V-ID: 09542526-c5df-41fa-9ae6-f3e4227b8873 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-26_08:,, signatures=0 Received: from [17.235.30.66] (unknown [17.235.30.66]) by nwk-mmpp-sz09.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPSA id <0PWV000626F6W4B0@nwk-mmpp-sz09.apple.com>; Mon, 26 Aug 2019 14:59:31 -0700 (PDT) Sender: afish@apple.com From: "Andrew Fish" Message-id: <0ED23C22-D224-40E0-BB57-ACA8F1ABCEA1@apple.com> MIME-version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [edk2-devel] git submodule update --init --recursive Date: Mon, 26 Aug 2019 14:59:25 -0700 In-reply-to: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC1E6@SHSMSX104.ccr.corp.intel.com> Cc: "devel@edk2.groups.io" , "rebecca@bsdio.com" To: "Gao, Liming" References: <83E89A1F-25F0-40ED-BE33-6843030DFEE4@apple.com> <35027f0c-51f3-a37a-c94a-b3df084c3981@bsdio.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC1E6@SHSMSX104.ccr.corp.intel.com> X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-26_08:,, signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_1879DA70-6A72-4479-8AE5-5720C2D3561C" --Apple-Mail=_1879DA70-6A72-4479-8AE5-5720C2D3561C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Liming, I see the usage of Submodules is documented at the end of the Readme.md. I= would not think of going to a Submodules section to figure out how to get = started or clone the repo.=20 I did not think of reading the full Readme.md as most of it is about "How= to Contribute to" not how to use the repo.=20 >>From TianoCore.org I followed this path: https://www.tianocore.org/getting-started.html https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with= -EDK-II https://github.com/tianocore/tianocore.github.io/wiki/Windows-systems or https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions-= for-Unix The git clone instructions don't include the "git submodule update --init"= instructions and the OVMF build failed.=20 bash$ mkdir ~/src bash$ cd ~/src bash$ git clone https://github.com/tianocore/edk2 Thanks, Andrew Fish > On Aug 25, 2019, at 8:54 PM, Gao, Liming wrote: >=20 > edk2\Readme.md Submodules section gives the command to update edk2 proje= ct.=20 >=20 > Thanks > Liming >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> rebecca@bsdio.com >> Sent: Saturday, August 24, 2019 6:24 AM >> To: devel@edk2.groups.io; afish@apple.com >> Subject: Re: [edk2-devel] git submodule update --init --recursive >>=20 >> On 2019-08-23 14:41, Andrew Fish via Groups.Io wrote: >>> I was following the instructions on how to build OVMF and my build fai= led. It >> looks like the reason it failed was because I did not do a `git submodu= le >> update --init --recursive`. It would be good if we could make how to cl= one the >> edk2 instructions a bit more obvious. >>=20 >>=20 >> I think we came to the conclusion that "--recursive" isn't needed. But >> I've found that there are cases where "--force" is required to make sur= e >> git checks out a submodule correctly. >>=20 >>=20 >> -- >> Rebecca Cran >>=20 >>=20 >>=20 >=20 --Apple-Mail=_1879DA70-6A72-4479-8AE5-5720C2D3561C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Liming,

I see the usage of Submodules is docu= mented at the end of the Readme.md. I would not think of going to a Submodu= les section to figure out how to get started or clone the repo. 
=

I did = not think of reading the full  Readme.md as most of it is about "= How to Contribute to" not how to use the repo. 
<= br class=3D"">
From TianoCore.org I followed this path:

or


The git clone instructions don't include the "git submodule upda= te --init" instructions and the OVMF build failed. 

bash$ mkdir ~/src
bash$ cd ~/src
bash$ git clone h=
ttps://github.com/tianocore/edk2

Thanks,

Andrew Fish
=
On Aug = 25, 2019, at 8:54 PM, Gao, Liming <liming.gao@intel.com> wrote:

edk2\Readme.md Submodul= es section gives the command to update edk2 project.

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Be= half Of
rebec= ca@bsdio.com
Sent: Saturday, August 24, 2019 6:24 AM
To: devel@edk2.groups.io; afish@apple.com
Subject: = Re: [edk2-devel] git submodule update --init --recursive

On 2019-08-23 14:41, Andrew Fish via Groups.Io wrote:
I was following the instruction= s on how to build OVMF and my build failed. It
l= ooks like the reason it failed was because I did not do a `git submoduleupdate --init --recursive`. It would be good if we could make h= ow to clone the
edk2 instructions a bit more obvious.


I think we came to the conclusion that= "--recursive" isn't needed. But
I've found that there are ca= ses where "--force" is required to make sure
git checks out a= submodule correctly.


--
Rebecca Cran





--Apple-Mail=_1879DA70-6A72-4479-8AE5-5720C2D3561C--