From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web11.6673.1617308758899110663 for ; Thu, 01 Apr 2021 13:25:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RwDaW6Az; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id x7-20020a17090a2b07b02900c0ea793940so3671950pjc.2 for ; Thu, 01 Apr 2021 13:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iQK3Vq2Fl3Jgfv45PixE89p+C7R6habFlrkvAGOsoEA=; b=RwDaW6Az68qDr3ZZrCu04KNO4FGYX8sQFDclmf8Jfyyc25gTGjvBtTzbHVLruiXn+W J7T56l/MhFY+w+TyVDuO/tV1w+iS7whc8W1W6WN9hOO7bveKz443DlmaOz24usi+uhbT dlkcuMX79HEyk/fk40RM1N3XQ3bvw+JLpP5peQZ6xnLItKk6b6/N34HA0g7c54aYkCr9 wR+t9Cj6EVKB35S2hJy2OWyYzOmMTwPis+E3of6ZfRHKb/OFZCDs416u0HPlCWh2m1B/ As/TTwArJhxnnfJP/bI3PfI4S3TVr696VsGtYXd36aU1N1qmL2J0ISXt0c2EshYCFpM+ sDLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iQK3Vq2Fl3Jgfv45PixE89p+C7R6habFlrkvAGOsoEA=; b=LCwEBvApTWiVwjR/0aqyXYXpslFrWrR59Yy291aoYR4swnTdE6JAuX4nHM9L5P/E/M NIsbUykp+rUoAUtwCtHFZ60UvOWc34Nrum/nwXS6uaxawcnP5+dbpQ4R48vGA2K8T2Q1 q9h1/Wq9T0BtI0dShHYTm+VtmQrT5xr2ShOM+1DNl/gDpwl2IYirBAgAA52obqopeHDj yifmiS8s7SGg3JtBw8XAU08/XlH44svsn5JNKIc2k3VVIXLVhsIWmEKc2Cz5D51xekz7 oDRQKYNgDOkpU/u9POEiyns2uCCGOM3mrYqc+lFmgLOhZaDiKJkxkQ/Z/o2Y9tGUHBOi tUpw== X-Gm-Message-State: AOAM5304/bIxJMd/9N70PXy9gtbfWXtafPo+GW7tO7bSEigbcb1BeuRn cM0g9Z3OwEBxixQjalRq8duda7UP09bJwQ== X-Google-Smtp-Source: ABdhPJwFxWK87eJCRlRHRlPg5wWMwdTj1g3LHw7dPACm1sgexwHHvnNvcRORuw1xOGZrH0taLlrSfQ== X-Received: by 2002:a17:902:d488:b029:e7:1f29:aee4 with SMTP id c8-20020a170902d488b02900e71f29aee4mr9695012plg.62.1617308758312; Thu, 01 Apr 2021 13:25:58 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id t4sm6177873pjs.12.2021.04.01.13.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 13:25:57 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Sun, Zailiang" , "Qian, Yi" References: <20210316181038.1413-1-kuqin12@gmail.com> <20210316181038.1413-5-kuqin12@gmail.com> From: "Kun Qin" Message-ID: <0a1345a6-04c9-aeb8-53c5-af92067f23ca@gmail.com> Date: Thu, 1 Apr 2021 13:25:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Thanks for your review, Michael. Could any maintainer please help merging this specific patch? All other patches in this series are already merged into mainline by Liming here (https://edk2.groups.io/g/devel/message/73035). Please let me know if it is preferable for me to send this single patch in a v3 after rewriting the commit message with reviewed-by tag. Thanks in advance! Regards, Kun On 03/30/2021 19:06, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Kun Qin >> Sent: Tuesday, March 16, 2021 11:11 AM >> To: devel@edk2.groups.io >> Cc: Sun, Zailiang ; Qian, Yi ; Kinney, Michael D >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for >> VariableSmmRuntimeDxe >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 >> >> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc >> file to resolve new dependency by VariableSmmRuntimeDxe. The library >> interface is consumed by variable module to better support variable >> runtime cache feature. >> >> Cc: Zailiang Sun >> Cc: Yi Qian >> Cc: Michael D Kinney > >> Signed-off-by: Kun Qin >> --- >> >> Notes: >> v2: >> - Added Michael K. to cc list [Zailiang] >> >> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + >> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> index 409f31c982d7..33e93b74800c 100644 >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> @@ -311,6 +311,7 @@ [LibraryClasses.IA32] >> LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf >> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf >> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf >> + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf >> >> [LibraryClasses.IA32.DXE_DRIVER] >> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> index 38bd825c8bdc..f7a876353649 100644 >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> @@ -313,6 +313,7 @@ [LibraryClasses.X64] >> LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf >> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf >> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf >> + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf >> >> [LibraryClasses.X64.DXE_DRIVER] >> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf >> -- >> 2.30.0.windows.1 >> >> >> >> >> >