From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mx.groups.io with SMTP id smtpd.web11.3042.1659987457722097273 for ; Mon, 08 Aug 2022 12:37:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=i0DUMhUl; spf=pass (domain: gmail.com, ip: 209.85.210.182, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f182.google.com with SMTP id u133so8936322pfc.10 for ; Mon, 08 Aug 2022 12:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=BtRoCmZ2C8CmL76kCmSpnvxEcoFQU969cjspNDACqkk=; b=i0DUMhUlf1a3gYqbXzv4/aq1+VJJJEpqVzBM2d5FK6sDotlEsMtbfuwtzwvFiZt+3x UZ1rv9KceiwNLNM9GzNGdeWEbZqnPEI6DBCnXir3fWRxzE46cewQV98GDAEPqxX7gXjz yK8ImmunkXMVIyxG4QRfxtiXYGhwsvKSDVkGm4tbE2k1MVrGDbn6XAWAyJ+258GCwKRw Z/DByhUefIq4TeKgJT8cU8ZQlN/v1dlaEveSaN9Bs3mjAFBRksIhZ9CLWR0dBqbbvT69 Xi9hh/AWvmKLEdFUwaYbNSqdI0+Sx5fhGFtAX41D6/wr0wp+AjDGUF/UJAJz/wxzx4s9 Adiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=BtRoCmZ2C8CmL76kCmSpnvxEcoFQU969cjspNDACqkk=; b=d+nRd89h1c3eixXQAJHR+aBSvC+HAwQVtvOmR5uIfPjJZXlODK9g3t/XX3MMEUjEP0 nvzZf7BREhkdUlewfqKoIEUAUWozeRD+nWbY7NYRKEDHF7OpcqmAKWhzGQTcFyE+j9Xr Od03wggDJ6QeCxU3wA4ZVMSghsctB5SFHwjPj9lVQxvPW2z0qUGCY+B5nPXa2uyaOocb FLIL63+W3sUpJDEFVlRZUQDcooC99wWOLlhogkKrzO8bT7PHEAHFrx1+V4nNaHxG9eHE vTbTb80yasCoDrOXzF+5ZKzwV7l1jMOzK4Cjp4t5lxIKfaiPUzIudfSGNrEVnSSgrKtU /BXw== X-Gm-Message-State: ACgBeo3awKY9nwFk4BRoYP48WVWE135N2WMvDuqbAAI4os+plceejTbo RmPxA1pohDe1wewLIB4uEag= X-Google-Smtp-Source: AA6agR6pINjIc1l5QUi6xsCT7FdAo+8+e6y6TYpsncFNtKXDN457IRUbqy67kvkZwkPrZQQBgblLug== X-Received: by 2002:a65:5688:0:b0:3c2:1015:988e with SMTP id v8-20020a655688000000b003c21015988emr16558753pgs.280.1659987457205; Mon, 08 Aug 2022 12:37:37 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:6127:6127:813c:be8d? ([2001:4898:80e8:3:e146:6127:813c:be8d]) by smtp.gmail.com with ESMTPSA id p14-20020a170902780e00b0016ef6c2375fsm2184035pll.217.2022.08.08.12.37.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 12:37:36 -0700 (PDT) Message-ID: <0a33f1d6-4366-6e00-6376-cd6a5a196a50@gmail.com> Date: Mon, 8 Aug 2022 12:37:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules To: Sami Mujawar , "devel@edk2.groups.io" Cc: Alexei Fedorov , Pierre Gondois References: <1706D34FB5A53D97.608@groups.io> <62ba76e9-fab3-371b-088c-1368a492cc29@gmail.com> <2a2ecc26-fc8e-ec22-77ef-88fb2eff9221@gmail.com> From: "Kun Qin" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Sami, Thanks for the deep dive on those patches. I will work on the patches and reply on those threads. Regards, Kun On 8/8/2022 8:44 AM, Sami Mujawar wrote: > Hi Kun, > > I have just replied to your patch series. I think patches 4 & 5 may need some adjustment. > > Can you look into those, please? > > Regards, > > Sami Mujawar > > On 08/08/2022, 16:34, "Kun Qin" wrote: > > Hi DynamicTablePkg maintainers, > > Just a gentle ping on this patch series. If there is no further > feedback, can we merge > them into the mainline? Otherwise, any feedback is appreciated. > > Regards, > Kun > > On 8/3/2022 9:57 AM, Kun Qin wrote: > > Hi DynamicTablePkg maintainers, > > > > Do you have any further feedback on this patch series? Any input is > > appreciated. > > > > Thanks, > > Kun > > > > On 7/30/2022 10:37 PM, Kun Qin via groups.io wrote: > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997 > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 > >> > >> This patch series is a follow-up of previous submission: > >> https://edk2.groups.io/g/devel/message/91926 > >> > >> The main changes between v2 and v3 patches are: > >> - Added reviewed-by collected from previous iteration > >> - Added descriptions for newly introduced structures > >> - Updated functions names > >> > >> Current DynamicTablesPkg provide great support for creating dynamic ACPI > >> tables during boot time. > >> > >> However, there are some modules needs minor tweaks to expand support and > >> compatibility for OS requirements and platform needs. > >> > >> This patch series proposes a few fixes to resolve minor issues > >> discovered > >> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe. > >> > >> Patch v3 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v3 > >> > >> Cc: Sami Mujawar > >> Cc: Alexei Fedorov > >> Cc: Pierre Gondois > >> > >> Kun Qin (6): > >> DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to > >> inf > >> DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing > >> DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers > >> DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed > >> tables > >> DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM > >> space > >> DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI > >> config > >> > >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c > >> | 214 ++++++++++++-------- > >> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > >> | 176 ++++++++++++++++ > >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c > >> | 80 +++++++- > >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf > >> | 4 + > >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf > >> | 1 + > >> 5 files changed, 391 insertions(+), 84 deletions(-) > >> > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.