From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v4 0/8] Create a SSDT PCIe generator
Date: Mon, 13 Dec 2021 12:24:27 +0000 [thread overview]
Message-ID: <0a38e61a-0c9b-bb20-aa35-be4d478b1bbb@arm.com> (raw)
In-Reply-To: <20211209092505.1248326-1-Pierre.Gondois@arm.com>
Hi Pierre,
Thank you for this patch series.
This series looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 09/12/2021 09:24 AM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682
>
> As part of the DynamicTablesPkg, add a generator creating a
> SSDT table describing a PCIe bus.
> This patch-set also adds new functions to generate AML bytecode
> in the AmlLib.
>
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1781_Create_ssdt_pcie_generator_v3
>
> v4:
> - Run uncrustify and apply the required formatting. [Pierre]
> - No other change with v3. [Pierre]
> v3:
> - Use ASSERT_EFI_ERROR when possible. [Sami]
> - Fix typos and add comments. [Pierre]
> - Add new patch "DynamicTablesPkg: Fix multiple objects parsing".
> [Pierre]
> v2:
> The following patches were modified:
> - DynamicTablesPkg: AML Code generation for memory ranges
> - DynamicTablesPkg: SSDT Pci express generator
>
> Pierre Gondois (8):
> DynamicTablesPkg: AML Code generation for memory ranges
> DynamicTablesPkg: AML Code generation to create a named Package()
> DynamicTablesPkg: AML Code generation to create a named
> ResourceTemplate()
> DynamicTablesPkg: AML Code generation to add _PRT entries
> DynamicTablesPkg: Add AmlAttachNode()
> DynamicTablesPkg: Add Pci related objects
> DynamicTablesPkg: SSDT Pci express generator
> DynamicTablesPkg: Fix multiple objects parsing
>
> DynamicTablesPkg/DynamicTables.dsc.inc | 2 +
> DynamicTablesPkg/Include/AcpiTableGenerator.h | 5 +
> .../Include/ArmNameSpaceObjects.h | 86 +-
> .../Include/Library/AmlLib/AmlLib.h | 413 +++++
> .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 1460 +++++++++++++++++
> .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 138 ++
> .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf | 32 +
> .../SsdtPcieOscTemplate.asl | 80 +
> .../Library/Common/AmlLib/Api/AmlApi.c | 36 +
> .../Common/AmlLib/CodeGen/AmlCodeGen.c | 326 ++++
> .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 951 +++++++++++
> .../ConfigurationManagerObjectParser.c | 48 +-
> 12 files changed, 3568 insertions(+), 9 deletions(-)
> create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
> create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h
> create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf
> create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieOscTemplate.asl
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-12-13 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 9:24 [PATCH v4 0/8] Create a SSDT PCIe generator PierreGondois
2021-12-09 9:24 ` [PATCH v4 1/8] DynamicTablesPkg: AML Code generation for memory ranges PierreGondois
2021-12-09 9:24 ` [PATCH v4 2/8] DynamicTablesPkg: AML Code generation to create a named Package() PierreGondois
2021-12-09 9:25 ` [PATCH v4 3/8] DynamicTablesPkg: AML Code generation to create a named ResourceTemplate() PierreGondois
2021-12-09 9:25 ` [PATCH v4 4/8] DynamicTablesPkg: AML Code generation to add _PRT entries PierreGondois
2021-12-09 9:25 ` [PATCH v4 5/8] DynamicTablesPkg: Add AmlAttachNode() PierreGondois
2021-12-09 9:25 ` [PATCH v4 6/8] DynamicTablesPkg: Add Pci related objects PierreGondois
2021-12-09 9:25 ` [PATCH v4 7/8] DynamicTablesPkg: SSDT Pci express generator PierreGondois
2021-12-09 9:25 ` [PATCH v4 8/8] DynamicTablesPkg: Fix multiple objects parsing PierreGondois
2021-12-13 12:24 ` Sami Mujawar [this message]
2021-12-13 17:19 ` [edk2-devel] [PATCH v4 0/8] Create a SSDT PCIe generator Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a38e61a-0c9b-bb20-aa35-be4d478b1bbb@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox