From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.52]) by mx.groups.io with SMTP id smtpd.web09.10454.1639398283787626486 for ; Mon, 13 Dec 2021 04:24:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=un2OULQO; spf=pass (domain: arm.com, ip: 40.107.4.52, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YaRwLllGbfuL+3ZjYtzIkJNEWkeWrh58OCUt/IoHkIQ=; b=un2OULQO4zC00zivGTj4VbzRuiF58fqOBwNUNmjHTpbTR5Q9fPwE7tIWWJwd8nC7FE7Q+9DU61wEBtT4sEztSiUXqqwKuYgr4c29iouSrqFu7g+oaJBpTMAUGmcPDCZ6eWJDfH5oB2Tpb7JwsSNDEigN8OistcYVwqRujWQBKc0= Received: from AM6P193CA0090.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::31) by HE1PR0802MB2378.eurprd08.prod.outlook.com (2603:10a6:3:c8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec 2021 12:24:40 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::11) by AM6P193CA0090.outlook.office365.com (2603:10a6:209:88::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17 via Frontend Transport; Mon, 13 Dec 2021 12:24:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Mon, 13 Dec 2021 12:24:40 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Mon, 13 Dec 2021 12:24:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3c42ebe184a47416 X-CR-MTA-TID: 64aa7808 Received: from c852a823c124.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 783BEEB8-A1FB-47D5-8CE5-E3D2F1B1068A.1; Mon, 13 Dec 2021 12:24:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c852a823c124.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Dec 2021 12:24:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQ0Q8M+HlLrJs6e6SohMRnScoMB1R7nAU39TeXySo37oPwmZwdyrkYE+0LLXE5uSL6oKmtBpaHD/ogUvQ5yNu55b9HAti8LSbzSFwf6TiczmLA7DSH3Qs2DXysUSX1zOMMv2yDUnFOmPLsciz8+nuzr9J6rP9YH5SwPq3LxyDNmhAhAHWGcvVDOOJHoUYooyXYEfpgHMJNE0D49kGmb7qhHUMKkI2JPL3pRHwoIihrzcIknUEW5YkGjvXMRLLxVYxGbZi1xmw8IP6kGSt86eq4KXw22Iy/YksuWwa/mYVYpb/JOx5Qc5c6XqxYsRy54okTpUqdMHPlQsolUj+cpHVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YaRwLllGbfuL+3ZjYtzIkJNEWkeWrh58OCUt/IoHkIQ=; b=f7Ud7kP+nGB6NL5PWv4EnKybezdX5IoD/lEAGna58pedbkVNG1U5NQyfEdNtYiOeZJ++Z32eRTPlALHpEPCDu4boVlYrX/Cpt7vUqCSbHWTN5VFrtExx8qSFRQI2F0t1Y1N72g7d8b9o2yOhdqjM0JCJGIpx0Q8l7/OoUyW5xRdiLdOgWNVKmVHaj3wWSsdMXLeDPzz4/EymbP6gDytho6tsJbPJl5apgVkK5RWHPwWDYHeGLMx1DW5HBYUrrgoUCFqm5h6VHAAsN6J7wJXwy3eXIE5RMDi4hY9XgShOrOXG1iyXyY9dW8jina3ygTJTH0BxNt45Jz34Jd1RGq2PnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YaRwLllGbfuL+3ZjYtzIkJNEWkeWrh58OCUt/IoHkIQ=; b=un2OULQO4zC00zivGTj4VbzRuiF58fqOBwNUNmjHTpbTR5Q9fPwE7tIWWJwd8nC7FE7Q+9DU61wEBtT4sEztSiUXqqwKuYgr4c29iouSrqFu7g+oaJBpTMAUGmcPDCZ6eWJDfH5oB2Tpb7JwsSNDEigN8OistcYVwqRujWQBKc0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0802MB2531.eurprd08.prod.outlook.com (2603:10a6:203:a0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Mon, 13 Dec 2021 12:24:20 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Mon, 13 Dec 2021 12:24:20 +0000 Subject: Re: [PATCH v4 0/8] Create a SSDT PCIe generator To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , nd References: <20211209092505.1248326-1-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: <0a38e61a-0c9b-bb20-aa35-be4d478b1bbb@arm.com> Date: Mon, 13 Dec 2021 12:24:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211209092505.1248326-1-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0289.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::6) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO4P123CA0289.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::6) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Mon, 13 Dec 2021 12:24:20 +0000 X-MS-Office365-Filtering-Correlation-Id: 1a5849d6-2163-4ef3-ee1a-08d9be33892d X-MS-TrafficTypeDiagnostic: AM5PR0802MB2531:EE_|AM5EUR03FT018:EE_|HE1PR0802MB2378:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6q7eneL7VQ2kP4ycpNqhfYC5ANSIs3pCnpSwzSn/FF9oqxSmqfrbPm0gTNlFhpTIvnTUJ/0HLqWjQloy1eGxaaX4It+GCZwUsyF8YFkwJEiHx7DnG372NY4bY8NtGoS8YpeQLmIIeFNbXSMHts+AuMtu8M4wiToC6Yw5ey8x//RkRQ13LAK8XpcAgKGI5RuI2zsWl4DEAd28K+lql0hQNbJwkf9Nvsy/vWEsScq6sZ5rjUrgQ4cmw7GieSy0JiK7iMajlT2NMR3oXtlPj3p12NtK3jMunTF0lsMxaeGQrs+WS5UgHp+PvnJrLy2kz6ew9HlFmA7gjsW5jSVGZF3MyiqV7kFSo0gxWAOFSa662ocWpM8pIsJWx//oRy3uiscAN0pyReRoqpbKBp77gnmNvjQoiMzKNudu73TAKuPFcdW5UeAFEEitZNXv3uKH2kvdML7++HlqjlPvZrQWMw7uRYNdE/Ku/DbYHCwMq0WDBdGumdGIqbomPc78YBd9jYtiXkPNjgTFSB034YgJtu/JI2jz6h2vkvSCmWvslAlvRdtCD91lpSjG24BaEK/AokVBWfCFzFetDKoCplh39gCQ0sKMgUxTWO+ucnveQ+t7bSn3mMmrnHbsm3oNp+Taj6FVfYXc1YNuWqLTuuSJddRPFJU0n23bsZvYaG5MIgUHu3Ar30olnv+FF088N6Iv1pxu2a9oGxyH1E7JY+W2aiJPzOyAq6uCse40QQZYS+Zi3r4I1QUDTm1xJxFre2/EAj9+SQ3qrbqmrbd2rc/zg1QSXKRmRVEZgVYaR1f8OS6pkPZazVnxBqniRSXPgzX5J+f1XU0LHTcYoHHuS1yXzKP535zcE8leU27WmHnSByMENDFNSfJ3wbak+nzlCZNwYgGKpZuvVBK8NZb/5YKzA35/Qw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(52116002)(186003)(8676002)(83380400001)(86362001)(2906002)(316002)(53546011)(956004)(2616005)(38100700002)(38350700002)(31686004)(44832011)(5660300002)(26005)(6486002)(66946007)(66556008)(4326008)(31696002)(66476007)(8936002)(508600001)(16576012)(54906003)(966005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2531 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f14d04ba-e859-4f07-7061-08d9be337d32 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FzF/J7LlMCj604bTBHoj1n3ZWr3IQ40HLDi9CiHh+8JBIYe2/+JcxXBHhKajNiQeh656q7+KG492geomLuyLzx4e0ufBDXsTSnCFvVUU6mlf+0mgKBHlXfMMnBun8AA3s415lm9SOYDvwW9ATf2JSf+2yJMMJs7SMXHZZH2vJ0gxJnptIxZhzGLfUHkLUge9moLPwFw1bdUoffNlxPZNl8DBlkmBFEFtHiP4/DpDibJW9Pgl+coWDocMJ06RP9VGkyeZZWJuvIcbYKdRMVGUvt8XOsZEPOTn9/swz4NqXdXlitWe975oxR9k+5TvNkc7/nJroMJ12wRKUi1JyAv4tEMVUdxEf5inwFLbjDfdgjslp3VQo44zm0mYL8kSFkDb4iySZL2uZHuOwML+eMLmwXh+o+N55Eg3/GS4O0b0TDH5PxmTJgZzem0RtTrlVLVnzf04kR9BH08972XB7C85LyUFe/5XcA2iYoalz4IIrM8XDTdwDI8yalTaqOC9mAxKFfxt23ZnMzlyJMd8f822fx++YWE4gQ+zZYbvzylglJdzO64NgbvD+D3zi+i8Y+m2nTflxbQwdBxLa28DWEhmAPJ9PKuJRVlP9Y9+QHzgrc4ETlLFDBPeUeVe9tCMAweHBzTJ9Qf8ax8JHA6g85u28dC0/4VDsc9XuAtLhWf0i9HfW7WxtcjNI8QTO4nsKAkrP8NLuAic8CjvEIn6dz25hiQa2ulwA2p/3bdlgWEdThw0tSRuao3z3aQ41hizxEA3Fo/1K9qOqjWlyqg1WToRhaPzATDLaNkWnTDWCA+gwrRhIcNk4lvvC1FscUI3DJZeaU5bdK7vz+kgyKXiYTsLUFkeseck1UduGl3Hr51smDw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(86362001)(956004)(6486002)(26005)(31696002)(186003)(36860700001)(53546011)(2616005)(83380400001)(82310400004)(356005)(8676002)(31686004)(8936002)(44832011)(16576012)(336012)(316002)(966005)(36756003)(5660300002)(2906002)(508600001)(54906003)(70586007)(70206006)(47076005)(4326008)(81166007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 12:24:40.3109 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5849d6-2163-4ef3-ee1a-08d9be33892d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2378 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pierre, Thank you for this patch series. This series looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/12/2021 09:24 AM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682 > > As part of the DynamicTablesPkg, add a generator creating a > SSDT table describing a PCIe bus. > This patch-set also adds new functions to generate AML bytecode > in the AmlLib. > > The changes can be seen at: https://github.com/PierreARM/edk2/tree/1781_Create_ssdt_pcie_generator_v3 > > v4: > - Run uncrustify and apply the required formatting. [Pierre] > - No other change with v3. [Pierre] > v3: > - Use ASSERT_EFI_ERROR when possible. [Sami] > - Fix typos and add comments. [Pierre] > - Add new patch "DynamicTablesPkg: Fix multiple objects parsing". > [Pierre] > v2: > The following patches were modified: > - DynamicTablesPkg: AML Code generation for memory ranges > - DynamicTablesPkg: SSDT Pci express generator > > Pierre Gondois (8): > DynamicTablesPkg: AML Code generation for memory ranges > DynamicTablesPkg: AML Code generation to create a named Package() > DynamicTablesPkg: AML Code generation to create a named > ResourceTemplate() > DynamicTablesPkg: AML Code generation to add _PRT entries > DynamicTablesPkg: Add AmlAttachNode() > DynamicTablesPkg: Add Pci related objects > DynamicTablesPkg: SSDT Pci express generator > DynamicTablesPkg: Fix multiple objects parsing > > DynamicTablesPkg/DynamicTables.dsc.inc | 2 + > DynamicTablesPkg/Include/AcpiTableGenerator.h | 5 + > .../Include/ArmNameSpaceObjects.h | 86 +- > .../Include/Library/AmlLib/AmlLib.h | 413 +++++ > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 1460 +++++++++++++++++ > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 138 ++ > .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf | 32 + > .../SsdtPcieOscTemplate.asl | 80 + > .../Library/Common/AmlLib/Api/AmlApi.c | 36 + > .../Common/AmlLib/CodeGen/AmlCodeGen.c | 326 ++++ > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 951 +++++++++++ > .../ConfigurationManagerObjectParser.c | 48 +- > 12 files changed, 3568 insertions(+), 9 deletions(-) > create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c > create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h > create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieOscTemplate.asl > > -- > 2.25.1