From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web11.17829.1601376133930262843
 for <devel@edk2.groups.io>;
 Tue, 29 Sep 2020 03:42:14 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Q/QV7QYc;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1601376133;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QUTeYl4fjaPppIL/q9BDdUkjtEnhHxqBJVCeiXUMf8U=;
	b=Q/QV7QYcFTScJ63gAdd86pVTIC5mcPV4cm1m998actukXBUY8EeN1mMkfGpm+vfPwxG8jD
	1RDY/NBqhk4PKtRtjdNbuqXo0b13h0VzqZhG/hudjWPWFzjVZHOhCGFDifdH8Z14oC5B3j
	3R/ejAJcj5EYMzfvttda7uXbgjMGpMQ=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-357-mv-7Xcr3OTeaZ0LC5EYiyA-1; Tue, 29 Sep 2020 06:42:10 -0400
X-MC-Unique: mv-7Xcr3OTeaZ0LC5EYiyA-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E6521882FA0;
	Tue, 29 Sep 2020 10:42:08 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-40.ams2.redhat.com [10.36.113.40])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 4AB827881E;
	Tue, 29 Sep 2020 10:42:07 +0000 (UTC)
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
To: changab <abner.chang@hpe.com>, devel@edk2.groups.io
Cc: Nickle Wang <nickle.wang@hpe.com>, Andrew Fish <afish@apple.com>,
 Leif Lindholm <leif@nuviainc.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20200929094748.8391-1-abner.chang@hpe.com>
 <20200929094748.8391-5-abner.chang@hpe.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <0a44c2a4-e789-d620-a460-471a6433a6bb@redhat.com>
Date: Tue, 29 Sep 2020 12:42:06 +0200
MIME-Version: 1.0
In-Reply-To: <20200929094748.8391-5-abner.chang@hpe.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>  
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Abner Chang <abner.chang@hpe.com>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>