From: "Rebecca Cran" <rebecca@nuviainc.com>
To: Sami Mujawar <Sami.Mujawar@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library
Date: Mon, 16 Nov 2020 20:27:26 -0700 [thread overview]
Message-ID: <0a4f85ab-b569-3d63-8786-f55f26bac8d4@nuviainc.com> (raw)
In-Reply-To: <DB7PR08MB3097225FA8FAAA1D88A7F01184E30@DB7PR08MB3097.eurprd08.prod.outlook.com>
On 11/16/20 6:43 AM, Sami Mujawar wrote:
> I have reviewed the following files from this patch and my responses are inline marked [SAMI].
> ArmPkg/Include/Chipset/AArch64.h
> ArmPkg/Include/Library/ArmLib.h
> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c
> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
> ArmPkg/Library/ArmLib/AArch64/AArch64Support.S
> ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S
> ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S
> ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm
> ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c
> ArmPkg/Library/ArmLib/ArmLibPrivate.h
>
> Is it possible to split this patch into smaller patches, please? It will then be easier to review the remaining files.
Thanks! I've split the patch into much smaller changes and incorporated
your fixes. I'll send out a v4 soon.
--
Rebecca Cran
next prev parent reply other threads:[~2020-11-17 3:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 0:17 [PATCH v3 0/3] ArmPkg,MdePkg: Add Universal/Smbios and Drivers/VersionInfoPeim Rebecca Cran
2020-11-11 0:17 ` [PATCH v3 1/3] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h Rebecca Cran
2020-11-12 21:49 ` [edk2-devel] " Sami Mujawar
2020-11-19 12:00 ` Leif Lindholm
2020-11-11 0:17 ` [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBios.h with processor status data Rebecca Cran
2020-11-11 1:18 ` 回复: " gaoliming
2020-11-13 11:25 ` [edk2-devel] " Sami Mujawar
2020-11-19 12:05 ` Leif Lindholm
2020-11-11 0:17 ` [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library Rebecca Cran
2020-11-16 13:43 ` [edk2-devel] " Sami Mujawar
2020-11-17 3:27 ` Rebecca Cran [this message]
2020-11-19 12:58 ` Leif Lindholm
2020-12-07 4:59 ` Rebecca Cran
2020-12-07 17:11 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a4f85ab-b569-3d63-8786-f55f26bac8d4@nuviainc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox