From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by mx.groups.io with SMTP id smtpd.web10.3182.1605583649953019684 for ; Mon, 16 Nov 2020 19:27:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=JkdBXL39; spf=pass (domain: nuviainc.com, ip: 209.85.215.193, mailfrom: rebecca@nuviainc.com) Received: by mail-pg1-f193.google.com with SMTP id 34so11822570pgp.10 for ; Mon, 16 Nov 2020 19:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=jWm3TU+rtutu+ifL7zD5xb5rL/3E1ZT5UZ+Oed2vpdY=; b=JkdBXL39ir8ewjRKTTivVpBRZeP0OBDlhew74fopPy8pRnQcagjv0lX64n2GxTfL3c NDu1jCEiqhkFDchwDH4bMf5QNsUjml3fmDlYlgV2viRDQw6VMMJKr1XPJ7K5EQSHA67M KEwRz0hvZecHoitM1ayvnaKYmYmfiZZDVPNvVBc3rs0z2py/8Q5KypQQqj/bvBEgAkc+ CpXw0S7slsD7PaKHbMQAF705nCvj2PqKuZtKpEKkFYuXWupd3hU/cR/x40BXO8Pco7p8 goQW/9qifsTOvNaWj7Mwz7zcNVCcWRfReCU+onkipU6kmg+6VbSCKmJnKJqNTIiwpAGY ssPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=jWm3TU+rtutu+ifL7zD5xb5rL/3E1ZT5UZ+Oed2vpdY=; b=d+dwAdiW9ovBO7AuFcjkIsF1V2JFhE4+WkOoKiPBlQvHYChlZVStvNEkZnjXYWlWn2 LZ5Gn1UD/Q06qMUAtO4uPLQkG92ffmuvT77uSsFk2Np14OptaESOVdlnHKO7nJdzPrp7 z+h06yNN31EhJZU/iGBsXbbBlSnpQ/NFh0NSm89HZ7eAX28ENATW/YQ9Z4xsvTaB5s3r yJKQkUszZ/VhtSo4bquLpipEf80+kSniKvcO7GIsfGHkWZWztfamjvxG29xzQcYv28TA pjxG1xgNgxrTRdecZyjg261JYe2aNxZ5yD1zkyofP0G9TCn3YKxyaMssOhCWUp8sZKXm Y86w== X-Gm-Message-State: AOAM531CFcI/vS2pd6PJgVLNEOVMm5UTxqJfIsmgP1LpzuiGsp2QguOR +e0f06X/CEpY39Cxy4EqrJrDXg== X-Google-Smtp-Source: ABdhPJz7jrzbL36AfZyeoGMdHlA8xMrtYPyPTM6o152TLbqqcWAepJKuv2GFywM7z1mipYq+N3s47A== X-Received: by 2002:a17:90b:a57:: with SMTP id gw23mr2224576pjb.161.1605583649463; Mon, 16 Nov 2020 19:27:29 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id c9sm19663286pfc.197.2020.11.16.19.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2020 19:27:28 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library To: Sami Mujawar , "devel@edk2.groups.io" Cc: Leif Lindholm , Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu , nd References: <20201111001748.20217-1-rebecca@nuviainc.com> <20201111001748.20217-4-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: <0a4f85ab-b569-3d63-8786-f55f26bac8d4@nuviainc.com> Date: Mon, 16 Nov 2020 20:27:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 11/16/20 6:43 AM, Sami Mujawar wrote: > I have reviewed the following files from this patch and my responses are inline marked [SAMI]. > ArmPkg/Include/Chipset/AArch64.h > ArmPkg/Include/Library/ArmLib.h > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h > ArmPkg/Library/ArmLib/AArch64/AArch64Support.S > ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c > ArmPkg/Library/ArmLib/ArmLibPrivate.h > > Is it possible to split this patch into smaller patches, please? It will then be easier to review the remaining files. Thanks! I've split the patch into much smaller changes and incorporated your fixes. I'll send out a v4 soon. -- Rebecca Cran