From: "Oliver Smith-Denny" <osde@linux.microsoft.com>
To: devel@edk2.groups.io, rebecca@os.amperecomputing.com
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jian J Wang <jian.j.wang@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Dandan Bi <dandan.bi@intel.com>
Subject: Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned
Date: Thu, 18 Jan 2024 11:26:58 -0800 [thread overview]
Message-ID: <0a589fed-02f1-4598-bbbc-98bad0e8b04f@linux.microsoft.com> (raw)
In-Reply-To: <17AB84FD31479E00.28523@groups.io>
On 1/18/2024 10:38 AM, Oliver Smith-Denny wrote:
> I am suspicious that we are checking for the alignment before we
> adjust the memory for the guard. I'm wondering if we actually
> should do AdjustMemoryF (recalling function from memory) before
> we check the alignment.
>
Following up on this, this is very suspicious to me. If you change
the CoreInternalFreePages alignment check to something like:
EFI_PHYSICAL_ADDRESS CheckMemory = Memory;
UINTN CheckPages = NumberOfPages;
AdjustMemoryF (&CheckMemory, &CheckPages);
if ((CheckMemory & (Alignment - 1)) != 0) {
Status = EFI_INVALID_PARAMETER;
goto Done;
}
Does this solve your issue? I have to run to a meeting, but I can
write this in actual patch form (and give it a quick test) later.
Thanks,
Oliver
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114008): https://edk2.groups.io/g/devel/message/114008
Mute This Topic: https://groups.io/mt/103810212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-18 19:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 15:27 [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned Rebecca Cran via groups.io
2024-01-18 16:48 ` Oliver Smith-Denny
2024-01-18 17:42 ` Rebecca Cran via groups.io
2024-01-18 18:38 ` Oliver Smith-Denny
2024-01-18 18:45 ` Rebecca Cran via groups.io
2024-01-18 19:04 ` Oliver Smith-Denny
2024-01-18 19:26 ` Rebecca Cran via groups.io
[not found] ` <17AB84FD31479E00.28523@groups.io>
2024-01-18 19:26 ` Oliver Smith-Denny [this message]
2024-01-19 16:34 ` Rebecca Cran via groups.io
2024-01-19 20:03 ` Oliver Smith-Denny
2024-01-22 22:06 ` Rebecca Cran via groups.io
2024-01-23 1:53 ` Oliver Smith-Denny
2024-01-23 2:14 ` Rebecca Cran via groups.io
2024-01-24 18:29 ` Oliver Smith-Denny
[not found] ` <17ACD713D9397BBF.18300@groups.io>
2024-02-03 0:59 ` Oliver Smith-Denny
2024-02-05 17:22 ` Rebecca Cran via groups.io
2024-02-05 17:51 ` Oliver Smith-Denny
2024-02-05 17:58 ` Rebecca Cran via groups.io
2024-02-05 20:36 ` Oliver Smith-Denny
[not found] ` <17B111E492D567BB.26550@groups.io>
2024-02-06 4:20 ` Oliver Smith-Denny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a589fed-02f1-4598-bbbc-98bad0e8b04f@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox