Re: [Patch v5 03/22] pip_requirements.txt: Add python pip requirements file

["Laszlo Ersek" <lersek@redhat.com>]

Hi Mike,

On 11/11/19 09:40, Michael D Kinney wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> Add pip requirements file that is used to install the
> python pip modules build from the edk2-pytool-library and
> edk2-pytool-extensions repositories.
> 
> These python modules provide the extensions required to
> perform EDK II Continuous Integration(CI) builds.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
>  pip_requirements.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 pip_requirements.txt
> 
> diff --git a/pip_requirements.txt b/pip_requirements.txt
> new file mode 100644
> index 0000000000..4ad72cfc98
> --- /dev/null
> +++ b/pip_requirements.txt

Is the underscore (ASCII 0x5F) a typo / misunderstanding, or is it
intentional?

I never tested "pip_requirements.txt"; I tested "pip-requirements.txt"
(hyphen, ASCII 0x2D).

Thanks
Laszlo

> @@ -0,0 +1,17 @@
> +## @file
> +# EDK II Python PIP requirements file
> +#
> +# This file provides the list of python components to install using PIP.
> +#
> +# Copyright (c) Microsoft Corporation. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +# https://pypi.org/project/pip/
> +# https://pip.pypa.io/en/stable/user_guide/#requirements-files
> +# https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format
> +#
> +##
> +
> +edk2-pytool-library==0.10.*
> +edk2-pytool-extensions==0.12.*
>