From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.2295.1573466291480887173 for ; Mon, 11 Nov 2019 01:58:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HiJybeCj; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573466290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dGkbXYFjnkh2EswIyQSJvxCTpZ5io+vSQ9gmdjtbp8o=; b=HiJybeCjXSClrQvgusyhwZHXrW5tmHhQurOXM31qWS02AflQHzm8riWdPMKLf01gXYAcKY AMp/6SrPfPH0jqDPnxlaQ8aRI46Bw6rOYRCHNJRQtnYke5CbNG7oVqJof040bnNYzsM8tg 51VAWpUR/gjrc1gv80tqICzAO9XZS6U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-80-deTSBePQN7Kb35iXy9qKbQ-1; Mon, 11 Nov 2019 04:58:06 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6AE14107ACC6; Mon, 11 Nov 2019 09:58:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECD40100034E; Mon, 11 Nov 2019 09:58:03 +0000 (UTC) Subject: Re: [Patch v5 03/22] pip_requirements.txt: Add python pip requirements file To: Michael D Kinney , devel@edk2.groups.io Cc: Sean Brogan , Andrew Fish , Leif Lindholm , Liming Gao References: <20191111084107.5368-1-michael.d.kinney@intel.com> <20191111084107.5368-4-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <0a690fc0-e551-b94e-e129-d5f02d76a62a@redhat.com> Date: Mon, 11 Nov 2019 10:58:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191111084107.5368-4-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: deTSBePQN7Kb35iXy9qKbQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Mike, On 11/11/19 09:40, Michael D Kinney wrote: > From: Sean Brogan >=20 > Add pip requirements file that is used to install the > python pip modules build from the edk2-pytool-library and > edk2-pytool-extensions repositories. >=20 > These python modules provide the extensions required to > perform EDK II Continuous Integration(CI) builds. >=20 > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > Reviewed-by: Liming Gao > --- > pip_requirements.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 pip_requirements.txt >=20 > diff --git a/pip_requirements.txt b/pip_requirements.txt > new file mode 100644 > index 0000000000..4ad72cfc98 > --- /dev/null > +++ b/pip_requirements.txt Is the underscore (ASCII 0x5F) a typo / misunderstanding, or is it intentional? I never tested "pip_requirements.txt"; I tested "pip-requirements.txt" (hyphen, ASCII 0x2D). Thanks Laszlo > @@ -0,0 +1,17 @@ > +## @file > +# EDK II Python PIP requirements file > +# > +# This file provides the list of python components to install using PIP. > +# > +# Copyright (c) Microsoft Corporation. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +# https://pypi.org/project/pip/ > +# https://pip.pypa.io/en/stable/user_guide/#requirements-files > +# https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file= -format > +# > +## > + > +edk2-pytool-library=3D=3D0.10.* > +edk2-pytool-extensions=3D=3D0.12.* >=20