From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by mx.groups.io with SMTP id smtpd.web10.2136.1662485226003395857 for ; Tue, 06 Sep 2022 10:27:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UsOTETFC; spf=pass (domain: gmail.com, ip: 209.85.219.54, mailfrom: benjamin.doron00@gmail.com) Received: by mail-qv1-f54.google.com with SMTP id l5so8805857qvs.13 for ; Tue, 06 Sep 2022 10:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=AI3ZGbZdCe9D8Jdhi1Wm98ehdXIGprmTQLNwsI80TM8=; b=UsOTETFCnuyM7OWfRmVJiK3JLVAEPtpeAFVzE9IAz7SW33ptCnMKapRqCCH6A/GXes V1Dz9jfrNmwAmUSbdazdST7EEF/9qSgQTV0pEflvdcNO8MIfh3XamwzpyVxqiucJrRVx ajZNUsgOulya8b1OUMHhhiz7PbtfzqLid4yKElOvPhY9IstUKZWnYxUZfa1Do1yPRtHj Hs//EkSELifiLT6j1pXvorklQtIUGjKp+m2DbWb2irRH2O8nykLyQfb0LIhcEH+j3+Ey fDfLGN2h+l0QvWuxcwzYKW42WDECXXAllX60qLtSQbvWdLaEgZFTyj0sQrXrOOkbamyp UP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=AI3ZGbZdCe9D8Jdhi1Wm98ehdXIGprmTQLNwsI80TM8=; b=c0gSTw9AHmWI5PtdJiAaICSsvAG+4rfsdYMoK1qLrNbTheReGnO9Wjgv29OxqMqine 3YajCxedFCmxaXzU1O0hvqfoE4dOFRfKL7XNES+GgiTZeA66zUgjW+Obx2xYASRc4ulb X5Ds2Z7pXbVxow2ZcpotyXG0//gCYHSIcCT/0v1VlMEf/5Yfl0b+e9EK9RHEPHuH0OHu A8llsck3Y04UdwepOq2gHK3bZRFeQUPqphqA2Pj3cLsrlu2GAtkyZHYImh3Aw8zvE7OD R0UO5oBQtF31HCaqhGYd5Za7rqYn/VX6OGkdBAgAj14jfOcF35ipRPWlhn2KwmdqZGsL YJnw== X-Gm-Message-State: ACgBeo3ayrmqBbSNuFui4CpiCsjbiSVKAcwrEYx4J4Euq1Ux/aErZtK0 PisyZgpFfBN85fMfakUHZ/NC7jxhLapBZg== X-Google-Smtp-Source: AA6agR7PfWCJVgdgD6tDuH7yaW1enInTQ+iytS2eeKk1pJdK9tqWwsRNzU47E5BWWttDxRtE6Iiimw== X-Received: by 2002:a0c:f307:0:b0:4aa:a431:c184 with SMTP id j7-20020a0cf307000000b004aaa431c184mr2508725qvl.76.1662485224901; Tue, 06 Sep 2022 10:27:04 -0700 (PDT) Return-Path: Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:46bc:db07:bbf3:df6d]) by smtp.gmail.com with ESMTPSA id j2-20020a05620a410200b006b9ab3364ffsm12169038qko.11.2022.09.06.10.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 10:27:04 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Sai Chaganty , Isaac Oram , Nate DeSimone , Ankit Sinha , Chasel Chiu , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib Date: Tue, 6 Sep 2022 13:26:52 -0400 Message-Id: <0a6dd32438d554e03fa222a70593f7a99cfc19d1.1662484082.git.benjamin.doron00@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable SecBoardInitLib is called to enable serial port before SerialPortInitialize and DEBUG(). This is strongly assumed to be necessary for I2cHdmiDebugSerialPortLib in SEC phase, which presently initialises this way. No testing was performed before, it's assumed too risky unless the GPIO happens to have the desired default. Presently, DEBUG() works in SEC phase. Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Ankit Sinha Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/PlatformInit.c b/Platform/Intel/MinPlatformPkg/FspWrapper/Li= brary/SecFspWrapperPlatformSecLib/PlatformInit.c index ef89e3f31018..d74b07bc062b 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor= mSecLib/PlatformInit.c +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor= mSecLib/PlatformInit.c @@ -28,6 +28,12 @@ PlatformInit ( IN VOID *EndOfRange=0D )=0D {=0D + //=0D + // Board/Silicon initialization=0D + // Prepare controllers before enabling serial port=0D + //=0D + BoardAfterTempRamInit ();=0D +=0D //=0D // Platform initialization=0D // Enable Serial port here=0D @@ -41,7 +47,5 @@ PlatformInit ( DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange));=0D DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange));=0D =0D - BoardAfterTempRamInit ();=0D -=0D TestPointTempMemoryFunction (StartOfRange, EndOfRange);=0D }=0D diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Lib= rary/SecFspWrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/Whiskeylak= eOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/Platf= ormInit.c index 486c8c72616e..53f95c29bde5 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/Se= cFspWrapperPlatformSecLib/PlatformInit.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/Se= cFspWrapperPlatformSecLib/PlatformInit.c @@ -28,6 +28,12 @@ PlatformInit ( IN VOID *EndOfRange=0D )=0D {=0D + //=0D + // Board/Silicon initialization=0D + // Prepare controllers before enabling serial port=0D + //=0D + BoardAfterTempRamInit ();=0D +=0D //=0D // Platform initialization=0D // Enable Serial port here=0D @@ -41,7 +47,5 @@ PlatformInit ( DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange));=0D DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange));=0D =0D - BoardAfterTempRamInit ();=0D -=0D TestPointTempMemoryFunction (StartOfRange, EndOfRange);=0D }=0D --=20 2.37.2