From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.83]) by mx.groups.io with SMTP id smtpd.web08.329.1621022055759253875 for ; Fri, 14 May 2021 12:54:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=uFbVISMp; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.83, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6GLF9DQYzG2zVDA+ePU/DGEEkIlVXu9HWTCff5n3xnkPn6Gqq8XMxJgPY82unPCPhUGZhMiWXIOTUjuAnJRurL/kedJvF/kIZ4cDdJATq356OzhSZiclwOAd3TfnLzmB/D7Dj1MCW2ZB698BOtR4lwVkrm/fpuy4tG/9+OR4YyMlWRVSejs0D8Y2aYvEOIW7fAj5zKoQrJdMEXrh2HYTY6XChkamUar+grztMJNDl6wLVfXaMekvHpNmcmHZ2Bm/aTEBb+o/jfMguM8DKRfQ4NXpqtN50DvqVWJ0LZCFhZqZjyr00Mt6vYbHD40VQ584dM2HKvol0Pja+wL+FA33A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SmH4GlEc8Dk4/qowqMsCC3iSih3Vi29Z46Ed2AxGL9w=; b=jjbK7hS7iOLrgd2uZHKv3Ku6o5XatAKlurFNNnbzO/vhDO32P6OEh2Gdb5JWSpZghaUEmuFB/N8/fylUcHJ2nayBL0KbZ5kPfA838LQJHjvHF1M+obY4GJZEhyz5bPGKNILjusgnpAO6/iXM5LdSs+N9Iw74ktFEjIZE1ACCPzrMyXWjWBRLYjh2eN3MfaO/5mxTVMJLEx/JLLPUfkKXKKYi+e9Kj055q+NTqVwomr4pdty0zRAPduYlN03aGkdxJNexA24KaGtg1f4VDRuayUVUItsAiQbM220x+cRZy07p0CO2Qu9/2hL75BzIVi7ZvY0jFITbpsg7ubm3jMNBZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SmH4GlEc8Dk4/qowqMsCC3iSih3Vi29Z46Ed2AxGL9w=; b=uFbVISMpVj7YO0T5bZdOVLHqWdWCi2gXhTElFQ7B8oqII/JHfRFB2u2Z/kewU2C3fbUdtUzFXZTLojbtzN6HSxTqT18hOAQphPbcdOu11bBA2nsGxNx/TSNzWxgs3XdN16F2v6pD7m2nyZGnsXHEd2hQUKYX7UkPB3bLwdv9g8c= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR1201MB0124.namprd12.prod.outlook.com (2603:10b6:4:58::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Fri, 14 May 2021 19:54:13 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9%12]) with mapi id 15.20.4129.025; Fri, 14 May 2021 19:54:13 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSF0gVWVmaUNwdVBrZy9NcEluaXRMaWI6IFByb3Blcmx5IGNhc3QgZnJvbSBQQ0QgdG8gU0VWLUVTIGp1bXAgdGFibGUgcG9pbnRlcg==?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn CC: 'Brijesh Singh' , 'Eric Dong' , 'Ray Ni' , 'Laszlo Ersek' , 'Rahul Kumar' References: <008c01d74612$4d9428b0$e8bc7a10$@byosoft.com.cn> From: "Lendacky, Thomas" Message-ID: <0a7875c7-a51a-7914-1c6c-3edc30abfac2@amd.com> Date: Fri, 14 May 2021 14:54:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <008c01d74612$4d9428b0$e8bc7a10$@byosoft.com.cn> X-Originating-IP: [67.79.209.213] X-ClientProxiedBy: SN4PR0501CA0008.namprd05.prod.outlook.com (2603:10b6:803:40::21) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from office-linux.texastahm.com (67.79.209.213) by SN4PR0501CA0008.namprd05.prod.outlook.com (2603:10b6:803:40::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Fri, 14 May 2021 19:54:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83a49da2-05d7-4763-ee9f-08d917120be9 X-MS-TrafficTypeDiagnostic: DM5PR1201MB0124: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1eyYMG+Tab+5oZOMTwpg6LK3LWgiTumfxqxxLDtyTR1MZ8YB6tez+RzfhbuZvxa6UcjPR+sJAJB837d6sQ84SXX6V5+93kgcbx53BqrUcVYIAhX7Qo6WL3BaguFKX6ydVfn9FOSJ38XFOaFS9uvAoURsXpafLMJTaFCm6BZojMh1UQ8Gwi9YZ1HnRwLErGQCjANAsXmPuLslU3Ra2iEQp55xkbb/L5iPRUbQ8DkNcUcym09K6UfL0AG7G78jVl8hLYAGhiSzAK/0Av/VhgdxEoVv/w/xCe+acN6sKlwo5+HpIDwQ6N2xlDbB+xOpCtDasb+/lYi27GTBqgRTBYzBc0DoRd5DJLQ8tvSBkAgUnT16DdPp/anr++Go4mnc3FvMW4NQ1wvT9OsrS//AT4PbSLSwkMLQvTotmLxC6zRevqHekqTlvzHYgw3myCY+puFZAbbkAsck4vKoMqAfW0HPbrbwr3WWUKe1tiVH2rlznHwejpsgzu6jY42GP3YH9w9ol22KnmF2KYA68fvAPpV5wK/vdzEpEpLB9Y0Hk6lJHM8RA30Jao4A/aIiN954/jy/Xqv54VS8NRU/sh25JnqmCqyHE0fdOfgDac7auoLM3vxHPnu42oGL+MEZVV7G3p880p0EuxQhnsC9x2/RyxiBxogRalpbNPa5DDK2wiyRnAqO6RhvFheV+GT7RXPgZa2WXibwYIa8GJQuF6CUtYe+dawC6G0QOiBFPIgTqKWTj8JMx7up9lVpj8P+ShoFYY0N96XWQ5ImZbV1BrVAQ2CfFUhg4GolTs27HOsQFxommfCZ9GCQBWF/7V2sfmNleMeD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(31696002)(36756003)(8936002)(86362001)(2616005)(38100700002)(83380400001)(66476007)(26005)(5660300002)(956004)(66946007)(478600001)(16526019)(186003)(966005)(4326008)(2906002)(316002)(54906003)(6512007)(6486002)(66556008)(45080400002)(224303003)(31686004)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Lv+pZ+VWyM+jDQBZOgDxFS6G5zETEqO+fEHekupIOD91PZwx/lejzN/Z5KBb?= =?us-ascii?Q?/gXcCrFC4YEGdqjtl+lF6nKa+zDPkVMcgKoeLNevfLFEwnIRZZtHMO0satIP?= =?us-ascii?Q?M2Nfa0DK9FNFGUD/u2bhM4pULxsYV2bCU/EUogaWrgjxtXUdKZFE8vHdOpAx?= =?us-ascii?Q?QVexi5q7KvUiT3qOAryQ4l9KBOYoeuw9bMmqvxPfZBcMAJhAYdSU0m8ti1MZ?= =?us-ascii?Q?MTfL/Cjfma9n86+vaZH10/6hw58MwJE06VcV34gUiY2MgAAUW1gLwYbK7g9A?= =?us-ascii?Q?XSIGzGNnMqAe//5oZ0UThQ6e659IsT0F9CkL1HbnQPt1i+6zOnA0E4cM25/L?= =?us-ascii?Q?9kKqf5hQ1fPhH9dVzafBWaT+JaDZeyCxt7F2T7lWP3z4mR+2xyRtIYEPaoRg?= =?us-ascii?Q?GilZjBdsVKoA4BTMV5F9Lxfh3a6QON37pLMuKORSj04Krit/m2COYvlxlhl5?= =?us-ascii?Q?k18f7e5/ibBpMIvZv16LGS9ebxazx1SUl0HPO2UY3XlkLeEtViDyY3KAo3Tu?= =?us-ascii?Q?TKuZyF8cPcjeHF5wMdJgRgL97ndgm2cNNeMCjzBXWkS6GENFNIMaYHtQTEmL?= =?us-ascii?Q?7PPzzkfxPHhxvo0ApRg1ck0+KKvk5J/k90QOuwruHoRjvxkJWA4sB8sYkunT?= =?us-ascii?Q?0a3Gk8t9rAr0TDnsF14vkVf3x7FHtkCmar/ZglF/UvsUwffrrZZnMcH8KdZw?= =?us-ascii?Q?Me4wOaoldsBZkGs5fcwdmqT7rsjWKOwcJ9e1PdWmTvXD4I4HVaF1XhWHx9QR?= =?us-ascii?Q?DIWs/Wp7j/HPflmR1WAXD61qi1qbkhw+N82OtzPIDJigizabC13La8kYHesF?= =?us-ascii?Q?t8sCJ8U9w4KzftdtsVkHTeUorBS6aovZAUZdAUjRnQeFQx9YBOI+82zphKqc?= =?us-ascii?Q?4aAk02fj/x9yeoeDp7Oxvv3Kp6bQIl+/3w/yn+WEprUHCysXBotMqEwu3SwD?= =?us-ascii?Q?oVtVwHnZJvelEJNuDugJuJP/IkIk9BIyO7KY2/UOKmKWfR1QU6qS6WlPyzia?= =?us-ascii?Q?f4CswSI2NRtjKInwCa4jcAnyWGsNDtG8mRAjteNy8WjFZK2iznj2pAbN1QRF?= =?us-ascii?Q?3F6ZYS5Ne1dHThjB8HA6E11a51E5/5HGFj+czKPS3z2R5/B4xpzgH80myavD?= =?us-ascii?Q?7TcZRGue4US5qWZ7z2NchuPJKrkvRtINccL3GyROCoBlNHrwRcFXPPJq+Pfp?= =?us-ascii?Q?V2DZ+gjBEhBLg9lRhcv12nUUQD7m4Oj0NwicAY7SXHXD8XNcK/kScD6NjkL+?= =?us-ascii?Q?4miD4fJ4ZTJFeqZU6CNtznieyvxusVFZlGkdxrgJDjVwCDNfihLeZ8DwoX3s?= =?us-ascii?Q?zY44kIYjrf0yjlqJjlmFztpF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83a49da2-05d7-4763-ee9f-08d917120be9 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2021 19:54:12.9924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tkahS+StcUqYp5YCYrE6w+tgD0FF+O0DFwxyEhsK3K6PoF2Tm/EEr2v0sZuNmkLS5a9hmIaV7xP6YLBQut7DWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0124 Content-Type: text/plain; charset=gbk Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/10/21 10:04 PM, gaoliming via groups.io wrote: > Reviewed-by: Liming Gao Thanks, Liming. Sorry, for the delay, your email ended up in my Spam folder... urg, IT at its best. Anyway... The patch is changing enough that I don't think I should add your Reviewed-by: just yet. Look for a new version soon. Thanks, Tom >=20 >> -----=D3=CA=BC=FE=D4=AD=BC=FE----- >> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Lendacky, >> Thomas >> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA5=D4=C210=C8=D5 22:25 >> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io >> =B3=AD=CB=CD: Brijesh Singh ; Eric Dong >> ; Ray Ni ; Laszlo Ersek >> ; Rahul Kumar >> =D6=F7=CC=E2: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Properly cast = from PCD to >> SEV-ES jump table pointer >> >> BZ: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3385&data=3D04%7C01%7Ctho= mas.lendacky%40amd.com%7Ce447839eff4f4dfcf2f408d9142974b8%7C3dd8961fe4884e6= 08e11a82d994e183d%7C0%7C0%7C637566181281381668%7CUnknown%7CTWFpbGZsb3d8eyJW= IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&s= data=3DHy8B0K8gLfdQyPFtkIQlYGQ82r2f5x%2BRf0PkWilprjc%3D&reserved=3D0 >> >> A VS2012 build fails with a cast conversion warning when the SEV-ES wor= k >> area PCD is cast as a pointer to the SEV_ES_AP_JMP_FAR type. >> >> When casting from a PCD value to a pointer, the cast should first be do= ne >> to a UINTN and then to the pointer. Update the code to perform a cast t= o >> a UINTN before casting to a pointer to the SEV_ES_AP_JMP_FAR type. >> >> Cc: Eric Dong >> Cc: Ray Ni >> Cc: Laszlo Ersek >> Cc: Rahul Kumar >> Signed-off-by: Tom Lendacky >> --- >> UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c >> b/UefiCpuPkg/Library/MpInitLib/MpLib.c >> index 3d945972a025..dc2a54aa31e8 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c >> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c >> @@ -1265,7 +1265,7 @@ SetSevEsJumpTable ( >> UINT32 Offset, InsnByte; >> UINT8 LoNib, HiNib; >> >> - JmpFar =3D (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 >> (PcdSevEsWorkAreaBase); >> + JmpFar =3D (SEV_ES_AP_JMP_FAR *) (UINTN) FixedPcdGet32 >> (PcdSevEsWorkAreaBase); >> ASSERT (JmpFar !=3D NULL); >> >> // >> -- >> 2.31.0 >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20