From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.53810.1658324354639656439 for ; Wed, 20 Jul 2022 06:39:14 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C62F013D5; Wed, 20 Jul 2022 06:39:14 -0700 (PDT) Received: from [10.34.100.102] (pierre123.nice.arm.com [10.34.100.102]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 473623F70D; Wed, 20 Jul 2022 06:39:13 -0700 (PDT) Message-ID: <0a79fe66-1bdc-fb7b-54d6-39aa14283882@arm.com> Date: Wed, 20 Jul 2022 15:38:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [edk2-devel] [PATCH v1 0/6] Enhance DynamicTablesPkg modules To: devel@edk2.groups.io, kuqin12@gmail.com Cc: Sami Mujawar , Alexei Fedorov References: <20220719002254.1891-1-kuqin12@gmail.com> From: "PierreGondois" In-Reply-To: <20220719002254.1891-1-kuqin12@gmail.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Except for: [PATCH v1 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed tables [PATCH v1 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM space where I had some remarks, Reviewed-by: Pierre Gondois Thanks! On 7/19/22 02:22, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 > > Current DynamicTablesPkg provide great support for creating dynamic ACPI > tables during boot time. > > However, there are some modules needs minor tweaks to expand support and > compatibility for OS requirements and platform needs. > > This patch series proposes a few fixes to resolve minor issues discovered > in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe. > > Patch v1 branch: https://github.com/kuqin12/edk2/tree/dynamic_update > > Cc: Sami Mujawar > Cc: Alexei Fedorov > > Kun Qin (6): > DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf > DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing > DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers > DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed > tables > DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM > space > DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI > config > > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c | 200 ++++++++++++++++---- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 135 +++++++++++++ > DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c | 80 +++++++- > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 1 + > DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf | 1 + > 5 files changed, 379 insertions(+), 38 deletions(-) >