From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.4302.1622104960193899294 for ; Thu, 27 May 2021 01:42:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHUz3jB3; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lx3F4v2j7wUT5TBwKqfX8V4MFWugg0IXpJrBS1yVaPs=; b=BHUz3jB3uw97qgbWN3fy0MDenJYFYp/CsT3gsnYkKxD1RN5tjw8gPunrEKHPTK6Qjq3FQu QRTpLqwS+GTtsJWdPrUnBDoVMXx/VT/+O85p9hO+l2T3aNp+kBFxoi9/bYEDjZ2CHt51Fg 5miC2lifX+IP9ZOiwvA/vrPVPOmbeGQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-227-8YNBuGrPOdyFCv7IXYDkeQ-1; Thu, 27 May 2021 04:42:37 -0400 X-MC-Unique: 8YNBuGrPOdyFCv7IXYDkeQ-1 Received: by mail-wr1-f70.google.com with SMTP id t5-20020adfb7c50000b029010dd0bb24cfso1475513wre.2 for ; Thu, 27 May 2021 01:42:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lx3F4v2j7wUT5TBwKqfX8V4MFWugg0IXpJrBS1yVaPs=; b=kGv3cNYEN7GYoMRg7Os8Ehlwz6aiSCEV/m005/kem0IDUYENjSNGsx+QRg72ADnQo+ kLdxQQ3Itd30Ls3YZmQO2hxTI+Y/LkExYsrOn/aQAQCSpSy6GjgliYAqkxc/gcsXvex5 bjp6yu45s2gerUo00gvkbZKsaKpviuIpn/v5AyyOyJsqZUNLfxKVjPAK7XfBPnzvFeR/ p3jlKjAQ+Au1iH7ad++rhVL74hBvXf1J2QQn5rJXWa1pg21XWRPEsT3SkS7H6Mv1o3Xv 1dFixWqXeuvqEmqLQfzWkOLHtc+UXHfWaXFBj+wck6HqFnwoSYQebdetFqvxBozWYKtz tf6g== X-Gm-Message-State: AOAM532qLZjkp0HaZBwg0wCtOJ3K1z7VhlqjYui+IAfjNeh4QvB8EIQe 54scVdLOjV6QRyCOFHUEra1IhgjE4aafy4EUVIG+e1aRbXKgIaxGzT0KwZRke4qjGF8vdgM7h9x Lej6Jj3R5zJgabA== X-Received: by 2002:a5d:64a6:: with SMTP id m6mr2103461wrp.425.1622104956564; Thu, 27 May 2021 01:42:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuOULLXKOUC/t2nNGdvFsdd/2RqUlqu9TU8VtuVusR/aLy///Oq2m4P32WDUavV4vCGWxrUg== X-Received: by 2002:a5d:64a6:: with SMTP id m6mr2103444wrp.425.1622104956438; Thu, 27 May 2021 01:42:36 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id v7sm2199354wrf.26.2021.05.27.01.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:42:36 -0700 (PDT) Subject: Re: [PATCH 19/43] OvmfPkg/OvmfXen: make "PcdPciDisableBusEnumeration" Fixed-at-Build To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-20-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <0a9513c7-533c-bf60-645f-5bc7280f5e40@redhat.com> Date: Thu, 27 May 2021 10:42:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-20-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The OvmfXen platform specifies the dynamic access method for > "PcdPciDisableBusEnumeration" needlessly. > > After the DSC file sets the PCD to TRUE by default, the InitializeXen() > function in XenPlatformPei superfluously sets the PCD to TRUE again. There > are no other writes to the PCD in the platform. > > Make the PCD Fixed-At-Build, and remove the access (in fact, the whole > InitializeXen() function) from XenPlatformPei. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfXen.dsc | 2 +- > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 1 - > OvmfPkg/XenPlatformPei/Platform.h | 5 ----- > OvmfPkg/XenPlatformPei/Platform.c | 1 - > OvmfPkg/XenPlatformPei/Xen.c | 20 -------------------- > 5 files changed, 1 insertion(+), 28 deletions(-) Reviewed-by: Philippe Mathieu-Daude