public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Paulo Alcantara <pcacjr@zytor.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Andrew Fish <afish@apple.com>,
	 Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
	Mark Doran <mark.doran@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>,
	hao.a.wu@intel.com
Subject: Re: [PATCH v3 0/6] read-only UDF file system support
Date: Thu, 24 Aug 2017 19:26:11 +0200	[thread overview]
Message-ID: <0aa39046-ef5f-af3b-9e25-fb269a286ad5@redhat.com> (raw)
In-Reply-To: <cover.1503594062.git.pcacjr@zytor.com>

Hi Paulo,

On 08/24/17 19:12, Paulo Alcantara wrote:

> v3:
>   - Install UDF partition child handles with a Vendor-Defined Media
>     Device Path.
>   - Changed UdfDxe to check for Vendor-Defined Media Device Paths with a
>     specific UDF file system GUID when determining to whether or not
>     start the driver.
>   - Removed leading TAB chars in some source files identified by
>     PatchCheck.py tool.

If you don't change a given patch from v2 to v3, then please pick up the
Reviewed-by and similar tags that you receive for the patch during the
v2 review. That way we'll know that we don't have to re-review those
patches.

I reckon you didn't change the OvmfPkg and ArmVirtPkg patches between v2
and v3; is that right?

> Repo:   https://github.com/pcacjr/edk2.git
> Branch: udf-fs

It's best to push all versions of a patch set to different (versioned)
branches, and once pushed, never to change them. It lets people fetch
all versions at any time, and rebase / compare them.

Thanks!
Laszlo


  parent reply	other threads:[~2017-08-24 17:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 17:12 [PATCH v3 0/6] read-only UDF file system support Paulo Alcantara
2017-08-24 17:12 ` [PATCH v3 1/6] MdePkg: Add UDF volume structure definitions Paulo Alcantara
2017-08-24 17:12 ` [PATCH v3 2/6] MdeModulePkg/PartitionDxe: Add UDF file system support Paulo Alcantara
2017-08-24 17:12 ` [PATCH v3 3/6] MdeModulePkg: Initial UDF/ECMA-167 " Paulo Alcantara
2017-08-24 17:12 ` [PATCH v3 4/6] OvmfPkg: Enable UDF " Paulo Alcantara
2017-08-24 17:12 ` [PATCH v3 5/6] ArmVirtPkg: " Paulo Alcantara
2017-08-24 17:12 ` [PATCH v3 6/6] Nt32Pkg: " Paulo Alcantara
2017-08-24 17:26 ` Laszlo Ersek [this message]
2017-08-24 17:35   ` [PATCH v3 0/6] read-only " Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aa39046-ef5f-af3b-9e25-fb269a286ad5@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox