From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.92386.1638369227740125578
 for <devel@edk2.groups.io>;
 Wed, 01 Dec 2021 06:33:48 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C111143B;
	Wed,  1 Dec 2021 06:33:46 -0800 (PST)
Received: from [10.34.125.34] (e126645.nice.arm.com [10.34.125.34])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8424D3F5A1;
	Wed,  1 Dec 2021 06:33:44 -0800 (PST)
Subject: Re: [edk2-devel] [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Leif Lindholm <leif@nuviainc.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Sean Brogan <sean.brogan@microsoft.com>,
 Bret Barkelew <Bret.Barkelew@microsoft.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael Kubacki <michael.kubacki@microsoft.com>, Sami.mujawar@arm.com
References: <20211123212122.1348-1-michael.d.kinney@intel.com>
 <20211123212122.1348-3-michael.d.kinney@intel.com>
From: "PierreGondois" <pierre.gondois@arm.com>
Message-ID: <0abf8e5a-2a5d-f468-4fef-73343cf22118@arm.com>
Date: Wed, 1 Dec 2021 15:33:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211123212122.1348-3-michael.d.kinney@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Hi,

If the exceptions to the yaml files are added to allow the unscrustify patches to pass the CI tests, shouldn't the same exceptions be removed once the patches are merged ?

Regards,

Pierre

On 11/23/21 10:21 PM, Michael D Kinney via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
>
> Update package YAML files to ignore ECC errors that are
> already present.  These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> index 3dbbcc673bf0..03632e74df73 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> +++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
> @@ -19,7 +19,8 @@
>          ],
>          ## Both file path and directory path are accepted.
>          "IgnoreFiles": [
> -            "Scripts/Ds5/"
> +            "Scripts/Ds5/",
> +            "Drivers/PL061GpioDxe/PL061Gpio.c"
>          ]
>      },
>