From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.61089.1673542999917458036 for ; Thu, 12 Jan 2023 09:03:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EDSbimtp; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673542999; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OGlSNTikJ0t22TRxglHOwf+aRO9j29+YAWEN0C89jrY=; b=EDSbimtpomifQGgTBGDx3R3Icc5qkxdibg9yLInaGafRPBrK5dVa2DDQJkIFr7+eGtmzIX zw0ciSNSVhQvRH5yJjVuJgdQ9mHfGNb1axr0xcBISVg1e/H8BAd2y+f0WTlkbzHI/bZfCY 9pj0CIC6paD9+G6/FZHJuKG4yPQuM3c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-328-sD7-wRVLPy-XPuMAGaggwg-1; Thu, 12 Jan 2023 12:03:17 -0500 X-MC-Unique: sD7-wRVLPy-XPuMAGaggwg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D141685570E; Thu, 12 Jan 2023 17:03:16 +0000 (UTC) Received: from [10.39.192.93] (unknown [10.39.192.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A8D2E492B00; Thu, 12 Jan 2023 17:03:14 +0000 (UTC) Message-ID: <0ae227fb-7cbd-9db8-8714-d1cf65e00f9f@redhat.com> Date: Thu, 12 Jan 2023 18:03:13 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices From: "Laszlo Ersek" To: Ard Biesheuvel , devel@edk2.groups.io, dionnaglaze@google.com Cc: Gerd Hoffmann , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Xu, Min M" , Andrew Fish , "Ni, Ray" , Moritz Fischer , "Kinney, Michael D" Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20221108164616.3251967-1-dionnaglaze@google.com> <20221108164616.3251967-4-dionnaglaze@google.com> <75ed5959-fbb2-3343-e7d7-dfa17b4a2615@redhat.com> <79fc5c62-922c-0db2-2c12-8557d276cce3@redhat.com> In-Reply-To: <79fc5c62-922c-0db2-2c12-8557d276cce3@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/12/23 16:32, Laszlo Ersek wrote: > ... I've picked up the patches, picked up the pending feedback tags too, > and compared the result against Dionna's latest PR > . > > Beyond the Message-Id tags that git-am picked up on my side, I've found > another difference: patch#1 was originally authored by Sophia Wolf > , but that fact has been mangled in the first patch > of -- commit cd4c186f1099. > Namely, in commit cd4c186f1099, the original authorship is recorded as > another line in the commit message, when it should be reflected by the > Author meta-datum in git. So I'm going to stick with what I have, from > the list archive and git-am (git-am correctly translates the From: line > back to the Author meta-datum), for the new PR: > > https://github.com/tianocore/edk2/pull/3889 Commit range e5ec3ba409b5..9d70d8f20d0f.