From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by mx.groups.io with SMTP id smtpd.web10.6219.1601503153087848057 for ; Wed, 30 Sep 2020 14:59:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=GhZx2pDg; spf=pass (domain: nuviainc.com, ip: 209.85.210.43, mailfrom: rebecca@nuviainc.com) Received: by mail-ot1-f43.google.com with SMTP id s66so3408738otb.2 for ; Wed, 30 Sep 2020 14:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=to:from:subject:cc:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=062JZGOOXsemFuNE+KBed6IiethUV4egZ8aM7nfaU0Y=; b=GhZx2pDgca5oColZy69ARha4ny1prVUsq+B0T3GGJJfWXNahDGVc7hWA+VrFqAS7PP v99lWeDlpFtAjIlSHbMUhdUCLm4nsCMbrJ8S4q+hjgcWE+aTolLBYqn3LsoJOT2+T1Hr J3NrFKpvjud58WwPf9LF0+VIsY1pdubO/+MBubFLWyXbe01MBc8mdNRzWKfo5/LOcmN7 lBFOvWd05StGzimbkw2n2jd1CMZ1QCgrQKVeeYXX6W12U1aw0jwGrmWbMJ3UHC9i5tUs AlY3w1vGGQXqQ78zeAnQJ2TaJ2fybukHG52jz/+15ANZMszr/GM5DVohzKwARb0GZi+k 3DXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:cc:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=062JZGOOXsemFuNE+KBed6IiethUV4egZ8aM7nfaU0Y=; b=Et3ZDjnYb3Siq4oduj5ZZMtfEdySuHOsBj2iyv97Rmz2rP3TNujx3shWp8aJ1US5LT ZIL/tMK5nCHZp8fS327zeUXu2LhoHtin25s9Xj7cdBdoEGqhI/AahYv/8jAWE/M20PVl l468oTtWWnh46uo2fd+l84UEaVYn1SXgnF1SAOT6wFR1kylQv4ht8OpVYmCmF3mtQcZK NJz0EMEW5TBtPBwmQA+yx/JoSg1Zj8i5BLBSPyLyOtCsV8vQRzpptmkaUkaZuBWU/UI8 0wpTsjBxIVm6P4S+6pGfFcvVrDod3uU2TwBPFujcLvVKjEW7nGIDg/f18KXAKQ6y1ncb oPeg== X-Gm-Message-State: AOAM5300uRzlY/LuRVjnjsSlfHSNmtlKip6KKTen5mEdup8PBuaXF//6 PEQtH+d1mgIN651jQdD93KRyHg== X-Google-Smtp-Source: ABdhPJzKeBw1eag5zWm+XdIj09YuXxCKpSJBbMQYishWhrW+NL02Ahcn5l1VOE+eeTArKLkSV19bHw== X-Received: by 2002:a9d:5d2:: with SMTP id 76mr2617242otd.99.1601503152419; Wed, 30 Sep 2020 14:59:12 -0700 (PDT) Return-Path: Received: from [192.168.156.132] ([12.17.170.136]) by smtp.gmail.com with ESMTPSA id g26sm689362otn.77.2020.09.30.14.59.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Sep 2020 14:59:11 -0700 (PDT) To: devel@edk2.groups.io From: "Rebecca Cran" Subject: Ecc style errors when running EDK2 CI locally without specifying a target (NO-TARGET) Cc: Sean Brogan , Bret Barkelew , Liming Gao , Michael D Kinney Message-ID: <0b04d303-655f-7f4e-88b6-d63268fe234f@nuviainc.com> Date: Wed, 30 Sep 2020 14:59:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Is it expected that the EDK2 CI run without errors in NO-TARGET mode - that is, when "-t" isn't specified? When I run it locally with "stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5 -a X64,AARCH64" I get lots of errors: one in ArmVirtPkg/PrePi/PrePi.c about a missing comment above a function, and then loads in DynamicTablesPkg - e.g.: PROGRESS - --Running ArmVirtPkg: EccCheck Test NO-TARGET -- ERROR - ERROR - EFI coding style error ERROR - *Error code: 8003 ERROR - *The #ifndef at the start of an include file should use both prefix and postfix underscore characters, '_' ERROR - *file: .../edk2/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h ERROR - *Line number: 41 ERROR - *The #ifndef name [AML_HANDLE] does not follow the rules ERROR - When I specify "-t DEBUG,RELEASE,NOOPT" it completes successfully. -- Rebecca Cran