From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 19A9B2119C89A for ; Wed, 12 Dec 2018 02:22:02 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 118E630820D8; Wed, 12 Dec 2018 10:22:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-211.rdu2.redhat.com [10.10.120.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3431E5D9C8; Wed, 12 Dec 2018 10:22:00 +0000 (UTC) To: "Gao, Liming" , "edk2-devel@lists.01.org" References: <20181205144918.8112-1-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E38A5AC@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <0b2bd66d-95bc-9695-8c10-e73a7f8fe5da@redhat.com> Date: Wed, 12 Dec 2018 11:22:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38A5AC@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 12 Dec 2018 10:22:02 +0000 (UTC) Subject: Re: [Patch] edk2 Readme.md: Add edk2 release tag and edk2 release plan X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 10:22:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Liming, On 12/12/18 01:41, Gao, Liming wrote: > Hi, all > I don't get any comments on this change. So, I will push it this week. sorry that I didn't respond earlier. I think the structure of your patch series is confusing. The first patch is for the edk2 project README file. I saw that soon after you posted these patches, and I thought someone else should comment on the series. So I skipped the rest of the series as well. However, the second patch in the series (which is not numbered, but I can see the second patch was sent threaded under the first), is for the edk2 *wiki*. I think that's extremely confusing, modifying multiple *repositories* in a single patch email thread. The wiki patch should have been sent separately. Furthermore, the subject shouldn't be [edk2] [Patch] edk2 wiki: remove ... but [edk2] [Patch edk2-wiki] remove ... For two reasons: - This way reviewers will see at once that the *project* (repo) in question is the wiki. We always put the repo (e.g. edk2-platforms, edk2-staging) in the bracketed part. - When the patch is finally pushed to the wiki, the subject line of the commit should not say "edk2 wiki". The commit is made to the wiki repo anyway, so naming it in the commit message is redundant. Anyway, beyond the above meta-comments, I'm fine with the contents of the patches themselves. The article at preserves the list of features added in the November release. That link is added to Readme.md in the first patch, and in general, is a generic feature of github, for all projects. Thanks, Laszlo