Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Pierre,

Thank you for the review.

I have some comments marked inline as [SAMI].

Regards,

Sami Mujawar

On 14/07/2022 09:01 am, Sami Mujawar wrote:
> Hi Masahisa,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 14/07/2022 07:38 am, Masahisa Kojima wrote:
>> Hi Sami,
>>
>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>> also requires the VariableFlashInfoLib library.
>> I have checked that the build error is fixed with the following 
>> modification.
>>
>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>> @@ -111,7 +111,7 @@ [LibraryClasses]
>>
>> NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
>> NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf
>> -
>> + 
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>
> [SAMI] I think this change should have been part of the series at 
> https://edk2.groups.io/g/devel/message/89156. However, I will include 
> this change im my series.
>
> The platforms in edk2-platforms repository are frequently broken by 
> changes in edk2 repository. I believe this is due to the lack of 
> edk2-platforms CI and we really need to fix that.
>
> [/SAMI]
>
>> Thanks,
>> Masahisa Kojima
>>
>> On Wed, 13 Jul 2022 at 22:19, PierreGondois <pierre.gondois@arm.com> 
>> wrote:
>>> Hi Sami,
>>> I think
>>>     Silicon/NXP/NxpQoriqLs.dsc.inc
>>> also requires the VariableFlashInfoLib library. Otherwise:
>>>
[SAMI] Looks like there is no end to this. I will fix this as well, but 
can we see what is blocking your series at 
https://edk2.groups.io/g/devel/message/83803, please?

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3509

Ref: https://github.com/tianocore/edk2-pytool-extensions/pull/279

[/SAMI]

>>> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>>>
>>>
>>> On 7/12/22 16:40, Sami Mujawar wrote:
>>>> This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
>>>> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
>>>> feedback received. It also includes an additional patch that fixes
>>>> the build break in CelloBoard due to missing VariablePolicyHelperLib
>>>> dependency.
>>>>
>>>> The v2 patch series fixes the build break in Ampere/Jade and
>>>> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
>>>> and also updates the IORT revision macro.
>>>>
>>>> The IORT Rev E.d specification updates the IORT table revision
>>>> to 5. Following this the IORT table revision macro
>>>> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
>>>> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
>>>> this series updates the following platforms to reflect this
>>>> renaming:
>>>>    - FVP
>>>>    - Morello FVP
>>>>    - SGI
>>>>    - AMD/Styx
>>>>    - Socionext/SynQuacer
>>>>    - RaspberryPi
>>>>    - N1SDP
>>>>    - Ampere/Jade
>>>>    - Pythium/FT2000-4
>>>>
>>>> Note: This patch series is dependent on the edk2 patch series:
>>>>     "[PATCH v5 0/8] IORT Rev E.d specification updates"
>>>>     (https://edk2.groups.io/g/devel/message/91264), which must
>>>>     be merged in edk2 before this patch series can be integrated.
>>>>
>>>> The changes can be seen at:
>>>> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3 
>>>>
>>>>
>>>> Sami Mujawar (12):
>>>>     Platform/ARM: FVP: Update for IORT revision macro renaming
>>>>     Platform/ARM: Morello: Update for IORT revision macro renaming
>>>>     Platform/ARM: SGI: Update for IORT revision macro renaming
>>>>     Silicon/AMD/Styx: Update for IORT revision macro renaming
>>>>     Silicon/Socionext/SynQuacer: Update for IORT revision macro 
>>>> renaming
>>>>     Platform/RaspberryPi: Update for IORT revision macro renaming
>>>>     Platform/ARM: N1SDP: Update for IORT revision macro renaming
>>>>     Silicon/Ampere: Add VariableFlashInfoLib
>>>>     Platform/Ampere: JadePkg: Update for IORT revision macro renaming
>>>>     Silicon/Phytium: Add VariableFlashInfoLib
>>>>     Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro 
>>>> renaming
>>>>     Platform/LeMaker: Fix missing dependency on 
>>>> VariablePolicyHelperLib
>>>>
>>>> Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c 
>>>> | 2 +-
>>>> Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c 
>>>> | 2 +-
>>>> Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
>>>> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c 
>>>> | 2 +-
>>>> Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
>>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
>>>> Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
>>>> Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
>>>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>>>> Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
>>>> Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
>>>> Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
>>>>    12 files changed, 12 insertions(+), 9 deletions(-)
>>>>
>>>
>>> 
>>>
>>>