Re: [edk2-devel] [PATCH 4/4] EmbeddedPkg: list module-internal header files in INF [Sources]

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 7/19/19 6:43 PM, Laszlo Ersek wrote:
> The BaseTools build feature introduced for TianoCore#1804 / in commit
> 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file",
> 2019-06-10) logs some (non-fatal) warnings about unlisted internal header
> files. List those files explicitly.
> 
> Note: header files are added in lexicographical order only if the
> underlying INF file already keeps the [Sources] and [LibraryClasses]
> sections in lexicographical order. Otherwise, header files are added in
> rough "logical" order.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> ---
>  EmbeddedPkg/Library/FdtLib/FdtLib.inf     | 1 +
>  EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/EmbeddedPkg/Library/FdtLib/FdtLib.inf b/EmbeddedPkg/Library/FdtLib/FdtLib.inf
> index f5cd7591e24e..354c1709c953 100644
> --- a/EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +++ b/EmbeddedPkg/Library/FdtLib/FdtLib.inf
> @@ -20,6 +20,7 @@ [Defines]
>  #
>  
>  [Sources]
> +  libfdt_internal.h
>    fdt_empty_tree.c
>    fdt_overlay.c
>    fdt_ro.c
> diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> index 83a0edcb8d94..3c749ca22943 100644
> --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> @@ -27,6 +27,7 @@ [Defines]
>  #
>  
>  [Sources.common]
> +  PrePi.h
>    FwVol.c
>    PrePiLib.c
>  
>