From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.66, mailfrom: philmd@redhat.com) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Fri, 19 Jul 2019 10:08:49 -0700 Received: by mail-wm1-f66.google.com with SMTP id x15so29475220wmj.3 for ; Fri, 19 Jul 2019 10:08:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4ajNmql2Z/EK3dGCmGm6b7GtCg1eb0BVVi7AhFyonb0=; b=S+CHr5KDUXTCysyBirKAT3O2dlca3d/wMSqgpjetY9Cy5pvdCGZCFSGMaagEttX2x5 7u+NFouE6zKC7lw2fOD750PPykauVcVPxh4wGQlYoQoPhGyxqQjYbVdij0N7kcFBLMP2 oko6PcNNHfCc/ctDIk8XPXhd65IFXCJqUktidbbwow5okMJXPHyPNTb+u2ogDfmhPcHX x5Y6/P1Q7ggW4Tw+kwyI3qOdlJIx5JCTjljs8lCE2LiDcLt11MjF8yre1GtM0B+zr7C4 VRT+/EN8N22MVjoIip2G15zDq75jt/Qefh+doVN/CJI3FBFAuZhlnhxxz6cb/icqqO0s rhCA== X-Gm-Message-State: APjAAAWQxKLb6Lus1yRyDmWZTmaE/uQX7WAbognFGRrOUtBlq+UN8U3A fpMUjJ11E5+pslZI9GZAjx1yFg== X-Google-Smtp-Source: APXvYqy0LyblVCMlpsvc/Iy41qfGJqMyQXb/NoOu4ghNNjtVXkTW6wTuz8SjKJcqzOtZYBFWSzYFpw== X-Received: by 2002:a1c:f515:: with SMTP id t21mr51354767wmh.39.1563556127316; Fri, 19 Jul 2019 10:08:47 -0700 (PDT) Return-Path: Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62]) by smtp.gmail.com with ESMTPSA id t13sm38257289wrr.0.2019.07.19.10.08.46 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 10:08:46 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 4/4] EmbeddedPkg: list module-internal header files in INF [Sources] To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Leif Lindholm References: <20190719164319.9070-1-lersek@redhat.com> <20190719164319.9070-5-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <0b49e9b3-bc56-00ab-b761-8ab620b7a13d@redhat.com> Date: Fri, 19 Jul 2019 19:08:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190719164319.9070-5-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/19/19 6:43 PM, Laszlo Ersek wrote: > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file", > 2019-06-10) logs some (non-fatal) warnings about unlisted internal header > files. List those files explicitly. > > Note: header files are added in lexicographical order only if the > underlying INF file already keeps the [Sources] and [LibraryClasses] > sections in lexicographical order. Otherwise, header files are added in > rough "logical" order. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude > --- > EmbeddedPkg/Library/FdtLib/FdtLib.inf | 1 + > EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/EmbeddedPkg/Library/FdtLib/FdtLib.inf b/EmbeddedPkg/Library/FdtLib/FdtLib.inf > index f5cd7591e24e..354c1709c953 100644 > --- a/EmbeddedPkg/Library/FdtLib/FdtLib.inf > +++ b/EmbeddedPkg/Library/FdtLib/FdtLib.inf > @@ -20,6 +20,7 @@ [Defines] > # > > [Sources] > + libfdt_internal.h > fdt_empty_tree.c > fdt_overlay.c > fdt_ro.c > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > index 83a0edcb8d94..3c749ca22943 100644 > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > @@ -27,6 +27,7 @@ [Defines] > # > > [Sources.common] > + PrePi.h > FwVol.c > PrePiLib.c > >