From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by mx.groups.io with SMTP id smtpd.web11.88140.1684157228468163158 for ; Mon, 15 May 2023 06:27:08 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@linaro.org header.s=google header.b=D2pGJChX; spf=pass (domain: linaro.org, ip: 209.85.218.46, mailfrom: marcin.juszkiewicz@linaro.org) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-96622bca286so2023286766b.1 for ; Mon, 15 May 2023 06:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684157227; x=1686749227; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=UBviVoAS5u8ql4AnZMP3njAkHQQv2a9wgdFrroNwR3M=; b=D2pGJChXiBDn3bB3JXiik5laRYD2bu+vzs/ezi+H/E0mkXjFcl6viNaooRpZaik/uw CrFQzKfm8zla7yJKgjJhT8x+/Ms7p1BiSfh0kxADRlIr3rkNpWRgcDma6E4zQzw0daVV k7jfiS8I40QOoN9sjVuXMGDRUY2elqigNxdPmxnfid5yzQcgwRbMQX8a6vG1l9I5QFLu cE8d/OgPoWkW3SvMr/aqou5SAFBUWKznxmCP+zAOmXUdQi8y3DDfSghxbxQ8P/Qsx6Oa eyx0aXjnbplrtC/R8XEzA/+NVJJDR1kyldEc9lmKTuhRbQdYlZT/HBNI3o9HXBFlV5E4 FVpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684157227; x=1686749227; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UBviVoAS5u8ql4AnZMP3njAkHQQv2a9wgdFrroNwR3M=; b=SnY3GLCIWlGWZ6x+2zW+yAlVcdSaczDBFl7xJSfSGqGUE2rJtowyQFzoOcLMr0jz1m EySz2lTpKYpxSQkINc3Hv69JC4VZjgxKLbOb0dDg4VLHkZ8CRtm7UxL80oOdYhwjHYXu +W6Zgdo5fJWq6artfyK5+wUVIiNYkmYMSRJ+oXF6r3kWSSasA/5eZHPE2RBJb/DjKvoN 2McC1/0NAGpg0WwPOE9hiH50bdJohCJZDo4OesiNMTCD1aKXEs0lrni+1rwq13O8/TKC UFM2AdcCPwIHN2BQOi2F+OL9TuMGHFs+X4I2un828h+BN1ZbCpE5Ju9/pyW+T0xH8cMz liHQ== X-Gm-Message-State: AC+VfDwrVSBiqDfQHEUi/QWu12eo4lc/fC2crnzrnr4poOSjnnwlT0EV aQskgjquQEI/QLQh9LX/QKjMXQ== X-Google-Smtp-Source: ACHHUZ4mPlZgbnBEjCK5BZIg8aEzDZl2J32dO+VVrMTOhmo+JJ20bB29vXKjZHHPQNNlZYsIzIFppA== X-Received: by 2002:a17:907:96a4:b0:966:14ca:8cf9 with SMTP id hd36-20020a17090796a400b0096614ca8cf9mr33136634ejc.38.1684157226691; Mon, 15 May 2023 06:27:06 -0700 (PDT) Return-Path: Received: from [192.168.200.206] (83.11.34.59.ipv4.supernova.orange.pl. [83.11.34.59]) by smtp.gmail.com with ESMTPSA id ig2-20020a1709072e0200b00965f31ff894sm9540694ejc.137.2023.05.15.06.27.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 06:27:06 -0700 (PDT) Message-ID: <0b4f5e90-3381-db7f-34c2-b7096e99a306@linaro.org> Date: Mon, 15 May 2023 15:27:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] Platform/SbsaQemu: read GIC base from TF-A To: Rebecca Cran , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <20230515102423.359916-1-marcin.juszkiewicz@linaro.org> <20230515102423.359916-3-marcin.juszkiewicz@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit W dniu 15.05.2023 o 15:14, Rebecca Cran pisze: > On 5/15/23 04:24, Marcin Juszkiewicz wrote: > >> +  /* If we are on platform version 0.0 then there is no more data for >> us in DeviceTree */ >> +  if ((Arg0 == 0) & (Arg1 == 0)) >> +  { >> +    return EFI_SUCCESS; >> +  } > > Should that be "&&" instead of "&"? Ops, yes. Always forgetting does C has "if ( (this) and (that) )" and then use wrong &/&& variant.